-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#230] 여행 조회, 여행 수정, 여행 나가기 뷰 / 서버통신 구현 #241
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
728690a
[FEAT/#230] 모듈 수정
crownjoe c794a44
[FEAT/#230] datasource 구현
crownjoe cf00a9b
[FEAT/#230] repository 구현
crownjoe 1062ce9
[FEAT/#230] Dto, Model 구현
crownjoe f35e81d
[FEAT/#230] 여행 수정 초기 뷰, 여행 수정 뷰 ui 수정
crownjoe f237268
[FEAT/#230] 충돌 수정
crownjoe 83962dc
[FEAT/#230] 머지 후 충돌 수정
crownjoe aa464bd
[FEAT/#230] 여행 디테일 조회 뷰 Model 구현
crownjoe 4de23c3
[FEAT/#230] 여행 디테일 조회 뷰 DataSource 구
crownjoe 1ae947b
[FEAT/#230] 여행 디테일 조회 뷰 Repository 구현
crownjoe ce5548a
[FEAT/#230] 여행 디테일 조회 뷰 서버통신 구현
crownjoe 32a5776
[FEAT/#230] 여행 디테일 조회 뷰 서버통신 구현
crownjoe e40579a
[FEAT/#230] 여행 디테일 조회 뷰 서버통신 구현
crownjoe 1adaa2f
[FEAT/#230] 여행 수정 뷰 서버통신 구현
crownjoe 255a142
[FEAT/#230] 컨플릭 해결
crownjoe c7ae49c
[FEAT/#230] 여행 수정 뷰 서버통신 구현
crownjoe 257cd3f
[FEAT/#230] 여행 수정 뷰 서버통신 로직 구현
crownjoe 15fe072
[FEAT/#230] 여행 수정 뷰 로직 수정
crownjoe f0b6e81
[FEAT/#230] 여행 나가기 뷰 서버통신 구현
crownjoe e8e0314
[FEAT/#230] 컨플릭 해결
crownjoe b24abe3
[FEAT/#230] 오류 수정
crownjoe 460c2b9
[CHORE/#230] 코리 반영 수정
crownjoe 08862e3
[CHORE/#230] 컨플릭 해결
crownjoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,26 +51,8 @@ class EditTripInfoActivity : | |
viewModel.currentEndDate = intent.getStringExtra(END_DATE) ?: "" | ||
|
||
binding.etEditTripInfoName.editText.setText(viewModel.currentTitle) | ||
|
||
val (startYear, startMonth, startDay) = splitDate(viewModel.currentStartDate) | ||
viewModel.currentStartYear.value = startYear | ||
viewModel.currentStartMonth.value = startMonth | ||
viewModel.currentStartDay.value = startDay | ||
viewModel.setStartDate(startYear, startMonth, startDay) | ||
|
||
val (endYear, endMonth, endDay) = splitDate(viewModel.currentEndDate) | ||
viewModel.currentEndYear.value = endYear | ||
viewModel.currentEndMonth.value = endMonth | ||
viewModel.currentEndDay.value = endDay | ||
viewModel.setEndDate(endYear, endMonth, endDay) | ||
} | ||
|
||
fun splitDate(date: String): Triple<Int, Int, Int> { | ||
val parts = date.split(".") | ||
val year = parts[0].toInt() | ||
val month = parts[1].toInt() | ||
val day = parts[2].toInt() | ||
return Triple(year, month, day) | ||
viewModel.splitStartDate() | ||
viewModel.splitEndDate() | ||
Comment on lines
+54
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 깔꼼쓰 ~~~~~ |
||
} | ||
|
||
private fun observePatchEditState() { | ||
|
@@ -125,8 +107,9 @@ class EditTripInfoActivity : | |
private fun initEditBtnClickListener() { | ||
binding.btnEditTripSave.setOnSingleClickListener { | ||
viewModel.patchTripInfoFromServer() | ||
val intent = Intent(this, DashBoardActivity::class.java) | ||
startActivity(intent) | ||
Intent(this, DashBoardActivity::class.java).apply { | ||
startActivity(this) | ||
} | ||
} | ||
} | ||
|
||
|
@@ -137,10 +120,10 @@ class EditTripInfoActivity : | |
} | ||
|
||
companion object { | ||
const val TRIP_ID = "TRIP_ID" | ||
const val TITLE = "TITLE" | ||
const val START_DATE = "START_DATE" | ||
const val END_DATE = "END_DATE" | ||
private const val TRIP_ID = "TRIP_ID" | ||
private const val TITLE = "TITLE" | ||
private const val START_DATE = "START_DATE" | ||
private const val END_DATE = "END_DATE" | ||
|
||
@JvmStatic | ||
fun createIntent( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
영상보니깐 바텀시트 값들이 2024 / 3 / 10 이 아니라 다른 형식이던데, 수정된 이유가 있었을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바텀시트에 뜨는 날짜 말씀하시는 거라면 영어로 뜨는 이유는 아마두 애뮬이 영어로 되어 있어서 그런 것 같숩니다.. 실기기에서는 원래 바텀시트 데이트피커 나오는 것(2024 3 10) 처럼 나옵니다!!