[FIX/#208] 투두 생성, 조회 뷰 / 메모 빈칸 대응 수정 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
reviewed
Feb 27, 2024
Comment on lines
+22
to
+23
| private val todo = MutableLiveData("") | ||
| private val memo = MutableLiveData("") |
There was a problem hiding this comment.
어떤경우에 LiveData를 사용하고, 어떤 경우에 StateFlow를 사용하는지 선택 기준이 궁금합니다!
저는 대부분 초기값이 있어야 하는 경우는 StateFlow를 사용하는 것 같습니다 :)
There was a problem hiding this comment.
StateFlow를 사용하는 것을 권장드리긴 합니다만,
LiveData를 사용해둔 부분들은 모두 xml과의 데이터바인딩이 연결된 변수들입니다!
StateFlow와 같은 경우는 계속해서 상태값을 지니고 있기에 백패킹(_달아주는거)으로 안정성을 보장해주는 것이 꼭 권장되는데,
백패킹으로 설정해두게 되면 데이터바인딩을 활용이 어려워졌었던 것 같아서 우선은 LiveData로 구현해뒀습니다.
LiveData가 이후에 deprecated된다면 데이터바인딩도 함께 사라질테니,
지금 상황처럼 데이터바인딩만을 위해서 변수 설정을 해두는 경우라면 LiveDat로 두어도 문제는 없을 것 같습니다 !
crownjoe
approved these changes
Feb 27, 2024
Comment on lines
+170
to
+175
| viewModel.endDate.observe(this) { | ||
| if (!viewModel.endDate.value.isNullOrEmpty()) { | ||
| with(binding) { | ||
| etTodoCreateDate.background = drawableOf(R.drawable.shape_rect_4_gray700_line) | ||
| tvTodoCreateDateHint.setTextColor(colorOf(R.color.gray_700)) | ||
| ivTodoCreateDate.setImageResource(R.drawable.ic_dropdown_gray700) |
Comment on lines
+22
to
+23
| private val todo = MutableLiveData("") | ||
| private val memo = MutableLiveData("") |
leeeyubin
approved these changes
Feb 28, 2024
Comment on lines
+22
to
+23
| private val todo = MutableLiveData("") | ||
| private val memo = MutableLiveData("") |
Comment on lines
+108
to
+111
| if (state.data.memo.isBlank()) { | ||
| with(binding) { | ||
| etTodoCreateMemo.background = drawableOf(R.drawable.shape_rect_4_gray200_line) | ||
| etTodoCreateMemo.text = stringOf(R.string.my_todo_create_tv_memo_hint) |
There was a problem hiding this comment.
with(binding) 습관화 하시는 것 같은데 좋네요!!
…into fix/#208-create-available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers