Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds language West-Central Oromo (gaz) #3157

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

DJ-Saidez
Copy link
Member

@DJ-Saidez DJ-Saidez commented Jan 26, 2025

This issue solves #3153

@jiru
Copy link
Member

jiru commented Feb 1, 2025

The flag is alright now, thank you!

@jiru
Copy link
Member

jiru commented Feb 4, 2025

Actually, the flag still needs some fixing.

  1. The ratio is currently 2:1 (1200×600) but it should be 3:2 instead.
  2. The SVG height/width should be set to 30×20.

I can make these changes if you want.

@DJ-Saidez
Copy link
Member Author

That would be great, thank you! That way I can see how to do it next time from the data I have here.

@jiru jiru merged commit a6b4c7d into Tatoeba:dev Feb 6, 2025
1 check passed
jiru added a commit that referenced this pull request Feb 6, 2025
Change ratio to 2:3 instead of 1:2.
Change default size to 20×30.

Refs #3157.
@jiru
Copy link
Member

jiru commented Feb 6, 2025

@DJ-Saidez The commit above does the necessary changes.

Changing the SVG height and width is just a matter of changing the height and width attributes of the <svg> root tag. It is the default size at which the browser should rasterize the image.

Changing the ratio however is a bit more complex, but the easiest way is to change the viewBox attribute. The viewbox is like a picture frame. Its values consist of the coordinates of a rectangle (top left corner x and y, width and height). After drawing the SVG elements, whatever part of the image that happens to be inside that rectangle will be visible in the final result; everything out of the rectangle is discarded. So, adjusting the viewbox lets you cut off some part of the image, effectively changing the height/width ratio. If you use a SVG editor to open the file, it will let you see the parts outside the view box:
gaz inkscape

@jiru jiru added this to the next milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants