Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(download): remove basic_auth header when password not exist #3772

Merged

Conversation

Sma1lboy
Copy link
Collaborator

@Sma1lboy Sma1lboy commented Jan 30, 2025

cc @wsxiaoys

This PR is to fix the 401 code encountered in #3771, and I also couldn't download all the models during testing

@Sma1lboy Sma1lboy marked this pull request as ready for review January 30, 2025 22:20
@Sma1lboy Sma1lboy changed the title fix(https): remove unused parsed_address and basic_auth from _get fun… fix(https): remove basic_auth from aim-downloader to get model response correctly Jan 30, 2025
@Sma1lboy Sma1lboy force-pushed the fix-model-cannot-download-by-auth-401 branch from 854e727 to 772f896 Compare January 31, 2025 01:48
@Sma1lboy Sma1lboy force-pushed the fix-model-cannot-download-by-auth-401 branch from c31c3b4 to 8aebc2d Compare January 31, 2025 02:24
@Sma1lboy Sma1lboy changed the title fix(https): remove basic_auth from aim-downloader to get model response correctly fix(https): remove basic_auth header when password not exist Jan 31, 2025
@wsxiaoys wsxiaoys changed the title fix(https): remove basic_auth header when password not exist fix(download): remove basic_auth header when password not exist Jan 31, 2025
@wsxiaoys wsxiaoys merged commit 9641479 into TabbyML:main Jan 31, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants