-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): add at feature with AT file implementation in VSCode #3602
base: main
Are you sure you want to change the base?
Conversation
5244117
to
ccad4a3
Compare
clients/vscode/src/chat/webview.ts
Outdated
.map((tab) => uriToListFileItem(tab.uri, this.gitProvider)); | ||
} | ||
|
||
const globPattern = `**/${query}*`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we validate the query string before injecting it into the glob pattern to ensure **/${query}*
is safe? For example, what if the query string contains *
or other special characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I have applied escapeGlobPattern to the query to prevent pattern matching, there is an issue where I cannot search for a file named *testfile.txt
using the query *
.
not git repo
in git repo