Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): add chat panel #2234

Merged
merged 19 commits into from
May 27, 2024
Merged

feat(vscode): add chat panel #2234

merged 19 commits into from
May 27, 2024

Conversation

wwayne
Copy link
Contributor

@wwayne wwayne commented May 24, 2024

Screen record

https://jam.dev/c/90c63fbe-4b83-49e0-9515-1040e284b352

Local testing

you might need to run pnpm build in the root folder first

UX bug (update: solved)

  1. don't open sidebar
  2. in the editor, select a piece of codes, right click and select tabby:explain this
  3. you will see the sidebar opened
  4. but you will see the initial page first, then it start paste your codes and start chatting (I've already asked @liangfung help to add a new props to the Chat component so I can handle such case better from vscode side)

Style syncing still has issue in a edge case (update: solved)

@wwayne wwayne requested a review from icycodes May 24, 2024 08:29
@wwayne wwayne marked this pull request as ready for review May 24, 2024 08:29
@liangfung
Copy link
Collaborator

@wwayne see pr #2235
Check if this is convenient enough, calling sendUserChat within the onLoaded callback. If not feasible, consider adding a parameter like initialUserMessage to the Chat component.

@wwayne wwayne marked this pull request as draft May 24, 2024 10:06
@wwayne wwayne assigned wwayne and unassigned wwayne May 24, 2024
@wwayne wwayne marked this pull request as ready for review May 24, 2024 11:04
@icycodes icycodes merged commit 571b75c into main May 27, 2024
4 checks passed
@icycodes icycodes deleted the vscode-chat branch May 27, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants