refactor(client): remove unused support proxy type and simplify metho…

…d checks
TabbyML · Jan 24, 2025 · 822a05a · 822a05a
1 parent 8575d95
commit 822a05a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 35 deletions.
diff --git a/clients/tabby-chat-panel/src/index.ts b/clients/tabby-chat-panel/src/index.ts
@@ -352,26 +352,13 @@ export interface ClientApiMethods {
   readFileContent?: (info: FileRange) => Promise<string | null>
 }
 
-type ClientApiMethod = keyof ClientApiMethods
-
-/**
- * Provide a convenient way to check if the client supports a specific method.
- */
-type SupportProxy = {
-  [K in ClientApiMethod]: boolean
-}
 export interface ClientApi extends ClientApiMethods {
   /**
    * Checks if the client supports this capability.
    * This method is designed to check capability across different clients (IDEs).
    * Note: This method should not be used to ensure compatibility across different chat panel SDK versions.
    */
   hasCapability: (method: keyof ClientApiMethods) => Promise<boolean>
-
-  /**
-   * The convenient accessor to check if the client supports a specific method from {@link ClientApiMethods}.
-   */
-  supports: SupportProxy
 }
 
 export function createClient(target: HTMLIFrameElement, api: ClientApiMethods): ServerApi {

diff --git a/clients/tabby-threads/source/targets/target.ts b/clients/tabby-threads/source/targets/target.ts
@@ -240,9 +240,7 @@ export function createThread<
     args: MessageMap[Type],
     transferables?: Transferable[]
   ) {
-    if (terminated) {
-      return;
-    }
+    if (terminated) return;
     target.send([type, args], transferables);
   }
 
@@ -282,7 +280,7 @@ export function createThread<
         .catch(() => {});
       return;
     }
-    // FIXME: don't ignore anything, just for testing now
+
     const isThreadMessageData =
       Array.isArray(rawData) &&
       typeof rawData[0] === "number" &&
@@ -510,29 +508,13 @@ export function createThread<
         {
           get(_target, property) {
             if (property === "then") {
-              console.warn("then not found");
+              console.log("target then", property);
+              console.log("_target", _target);
               return undefined;
             }
             if (property === "requestMethods") {
               return methods?.requestMethods;
             }
-            if (property === "supports") {
-              return new Proxy(
-                {},
-                {
-                  get(_target, method: string) {
-                    if (!state) return false;
-                    const cache = theirMethodsCache;
-                    console.log("cache for supports", cache);
-                    if (cache !== null && !state.isTerminated()) {
-                      return cache.includes(method);
-                    }
-                    return false;
-                  },
-                }
-              );
-            }
-
             if (
               theirMethodsCache &&
               !theirMethodsCache.includes(String(property))