refactor(iframe): streamline message event listener by removing unnec…

…essary conditional block refactor(chat-page): simplify capability checks by consolidating server support evaluations refactor(chat-webview): remove redundant logging during initialization
TabbyML · Jan 22, 2025 · 524913d · 524913d
1 parent 986119f
commit 524913d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 38 deletions.
diff --git a/clients/tabby-threads/source/targets/iframe/nested.ts b/clients/tabby-threads/source/targets/iframe/nested.ts
@@ -56,9 +56,7 @@ export async function createThreadFromInsideIframe<
     self.addEventListener(
       "message",
       ({ data }) => {
-        if (data === CHECK_MESSAGE) {
-          respond();
-        }
+        if (data === CHECK_MESSAGE) respond();
       },
       { signal: options.signal }
     );

diff --git a/clients/vscode/src/chat/webview.ts b/clients/vscode/src/chat/webview.ts
@@ -96,11 +96,9 @@ export class ChatWebview {
     };
     this.webview = webview;
 
-    this.logger.info("Initializing chat panel webview.");
     this.createChatPanelApiClient().then((client) => {
       this.client = client;
     });
-    this.logger.info("Chat panel webview initialized.");
     const statusListener = () => {
       this.checkStatusAndLoadContent();
     };

diff --git a/ee/tabby-ui/app/chat/page.tsx b/ee/tabby-ui/app/chat/page.tsx
@@ -28,6 +28,8 @@ import { MemoizedReactMarkdown } from '@/components/markdown'
 
 import './page.css'
 
+import { set } from 'date-fns'
+
 import { saveFetcherOptions } from '@/lib/tabby/token-management'
 import { PromptFormRef } from '@/components/chat/form-editor/types'
 
@@ -244,40 +246,20 @@ export default function ChatPage() {
         apiVersion: TABBY_CHAT_PANEL_API_VERSION
       })
 
-      if ('refresh' in server) {
-        // eslint-disable-next-line no-console
-        console.log('refresh in server')
-      }
-      // eslint-disable-next-line no-console
-      console.log('support v2?:', server?.supports['onApplyInEditorV2'])
-
-      const checkCapabilities = async () => {
-        server
-          ?.hasCapability('onApplyInEditorV2')
-          .then(setSupportsOnApplyInEditorV2)
-        server?.hasCapability('lookupSymbol').then(setSupportsOnLookupSymbol)
-        server
-          ?.hasCapability('readWorkspaceGitRepositories')
-          .then(setSupportsReadWorkspaceGitRepoInfo)
-        server
-          ?.hasCapability('listFileInWorkspace')
-          .then(setSupportProvideFileAtInfo)
-        server
-          ?.hasCapability('readFileContent')
-          .then(setSupportsReadFileContent)
-
-        Promise.all([
-          server?.hasCapability('fetchSessionState'),
-          server?.hasCapability('storeSessionState')
-        ]).then(results => {
-          setSupportsStoreAndFetchSessionState(
-            results.every(result => !!result)
-          )
-        })
+      setSupportProvideFileAtInfo(!!server?.supports['listFileInWorkspace'])
+      setSupportsReadFileContent(!!server?.supports['readFileContent'])
+      setSupportsOnApplyInEditorV2(!!server?.supports['onApplyInEditorV2'])
+      setSupportsOnLookupSymbol(!!server?.supports['lookupSymbol'])
+      setSupportsReadWorkspaceGitRepoInfo(
+        !!server?.supports['readWorkspaceGitRepositories']
+      )
+      if (
+        !!server?.supports['fetchSessionState'] &&
+        !!server?.supports['storeSessionState']
+      ) {
+        setSupportsStoreAndFetchSessionState(true)
       }
-      checkCapabilities().then(() => {
-        setIsServerLoaded(true)
-      })
+      setIsServerLoaded(true)
     }
   }, [server])