[FEATURE] Add command controller to create test data #1297

kanow · 2024-05-07T14:25:36Z

Simple command to add test data for tea model with a console command. It's just the first try and should be extended by more data, translations, etc.

Resolves: #1120

coveralls · 2024-05-07T14:27:22Z

Pull Request Test Coverage Report for Build 10167965078

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 10166538431:	0.0%
Covered Lines:	80
Relevant Lines:	80

💛 - Coveralls

sbuerk · 2024-05-07T22:03:16Z

I know this is WIP, but I wanted to provide an early feedback on this.

Basically, I would recommend to avoid using QueryBuilder or Connection
methods (low-level api) for such tasks, until absolutly needed. Usually,
it's more recommandable to use DataHandler for operation, as it takes
care of a lot of stuff. For example:

Default value handling (TCA)
TYPO3 system field handling
soft-delete/hard-delete of records based on TCA configuration
record history for changes (soft-delete, creation, updating, ...)
automatically exeucte hooks configured by extensions/core
workspace support if workspace is installed etc without the need to handle system fields directly
system field for localization of records (l18n_diff, l18n_source) etc
access verification (if not executed with admin permissions)

albeit eventually not having all in place right now.

Thus I highly recommend to switch to DataHandler for the deletion
and data creation/update part.

Classes/Command/CreateTestDataCommand.php

kanow · 2024-07-26T07:50:59Z

We are aware to the usage of DataHandler or not. Daniel means that Command Controller should be an simple example to work with database actions. Maybe later we can extend that existing command or create a second command controller that shows an advanced example to work with the DataHandler.
For example adding more data with relations to images.

Classes/Command/CreateTestDataCommand.php

oliverklee

Currently, the functional tests are failing. Also, we currently have some style warnings and PHPStan warnings which we'll need to fix first.

Configuration/Services.php

oliverklee

Currently, some tests are red. Could you please fix these and also rename the Composer script key as requested in an earlier review? Thanks! 🙏

lukaszuznanski · 2024-12-09T16:00:19Z

Hi,

We've implemented a policy to close pull requests that have been inactive for over six months. If you're still interested in contributing and would like to continue working on this pull request, we're more than happy to keep it open.

Please take a moment to review your pull request and let us know if you'd like to proceed with it. If we don't receive a response within the next 30 days, we'll assume that you no longer wish to pursue it, and we'll proceed with closing the pull request.

Feel free to reach out if you have any questions or need further assistance.

kanow · 2024-12-13T15:49:11Z

Oh, shit. And yes, I still try to make this PR ready to review/merge ;-).

coveralls · 2024-12-13T16:22:38Z

Pull Request Test Coverage Report for Build 12447292792

Details

34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 12349403373:	0.0%
Covered Lines:	101
Relevant Lines:	101

💛 - Coveralls

Related: #11120

Related: #1120

Co-authored-by: Oliver Klee <[email protected]>

Related #1120

SQLite does reset the UID autoincrement during deletion. That way the assertions do not match. We now use a different set up and remove the uids from assertions. That way we still ensure that the imported data is removed and new data is imported. We do not need to care about UID.

Related #1120

In php 7.4 error occured: `Cannot unpack array with string keys` Related #1120

functional test are failing all with that assert Related: #1120

With the usage of an integer in functional test for the command we get rid of the issue with asert is int or cast mixed variable to int. Test are running fine locally. The page id should be just an integer and nobody will be set that in '' right? Related: #1120

Related: #1120

kanow added this to the 4.0.0: Breaking changes milestone May 7, 2024

kanow self-assigned this May 7, 2024

kanow linked an issue May 7, 2024 that may be closed by this pull request

Add a command to create test data #1120

Closed

2 tasks

sbuerk reviewed May 7, 2024

View reviewed changes

Classes/Command/CreateTestDataCommand.php Outdated Show resolved Hide resolved

kanow force-pushed the 1120-add-a-command-to-create-test-data branch 2 times, most recently from 60272f9 to f28c1a3 Compare May 8, 2024 09:51

kanow changed the title ~~[WIP] Add command controller to create test data~~ Add command controller to create test data Jul 26, 2024

kanow force-pushed the 1120-add-a-command-to-create-test-data branch from bad530a to c3821cd Compare July 29, 2024 15:29

kanow requested a review from oliverklee July 29, 2024 15:33

oliverklee changed the title ~~Add command controller to create test data~~ [FEATURE] Add command controller to create test data Jul 29, 2024

oliverklee added the enhancement New feature or request label Jul 29, 2024

oliverklee requested changes Jul 29, 2024

View reviewed changes

kanow force-pushed the 1120-add-a-command-to-create-test-data branch 2 times, most recently from a2f9011 to 9902677 Compare July 30, 2024 17:14

oliverklee requested changes Jul 30, 2024

View reviewed changes

Configuration/Services.php Outdated Show resolved Hide resolved

kanow force-pushed the 1120-add-a-command-to-create-test-data branch 2 times, most recently from 6327a94 to 73b8069 Compare August 20, 2024 06:56

oliverklee requested changes Aug 23, 2024

View reviewed changes

linxpinx added the hacktoberfest label Sep 23, 2024

kanow force-pushed the 1120-add-a-command-to-create-test-data branch from a7101db to 055a2f0 Compare October 20, 2024 10:04

kanow force-pushed the 1120-add-a-command-to-create-test-data branch from 055a2f0 to 3c9a5b7 Compare December 13, 2024 16:00

oliverklee force-pushed the 1120-add-a-command-to-create-test-data branch from aa090fc to 4662572 Compare December 21, 2024 17:54

kanow added 2 commits December 21, 2024 18:57

[FEATURE] Add command controller to create test data

44cfc82

Related: #11120

[TASK] Remove phpDocumentor reflection type

aa624b2

Related: #1120

kanow and others added 21 commits December 21, 2024 18:57

[DOCS] Add documentation part for command controller

a067246

Related: #1120

[BUGFIX] Fix errors from php cs fixer

8e3de93

Related: #1120

Update Classes/Command/CreateTestDataCommand.php

41962da

Co-authored-by: Oliver Klee <[email protected]>

Update Classes/Command/CreateTestDataCommand.php

393e55f

Co-authored-by: Oliver Klee <[email protected]>

[TASK] Move comment directly above the class

91f27b0

Related #1120

[TASK] Rename pageId to pageUid

a430e32

Related #1120

[TASK] use assert to state data restrictions

d47b590

Related #1120

[TASK] Update reference index after changing test data

05c4c1a

Related #1120

[TASK] Remove unnecessary is_int check of pageUid

e96cdb0

Related #1120

[TASK] Add functional test for createTestDataCommand

9c3e7ef

Related #1120

[TASK] Check that existing teas in other pids were not deleted

a928788

Related #1120

[TASK] Rename test functions

06e39b3

Related #1120

[TASK] Remove unused imports

77f9b5c

Related #1120

[BUGFIX] Fix some php stan errors

d8fc929

Related #1120

[BUGFIX] Fix error with spread operator in php 7.4

ed08a12

In php 7.4 error occured: `Cannot unpack array with string keys` Related #1120

[BUGFIX] Remove assert of int for the page id

745f043

functional test are failing all with that assert Related: #1120

[TASK] Ignore error with missing type for constant

5ca9abe

Related: #1120

[TASK] Rename command to improve readability

5207568

Related: #1120

Some polish after review

c7f3aff

oliverklee force-pushed the 1120-add-a-command-to-create-test-data branch from 4662572 to c7f3aff Compare December 21, 2024 17:57

oliverklee approved these changes Dec 21, 2024

View reviewed changes

oliverklee merged commit 565666b into main Dec 21, 2024
56 checks passed

oliverklee deleted the 1120-add-a-command-to-create-test-data branch December 21, 2024 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] Add command controller to create test data #1297

[FEATURE] Add command controller to create test data #1297

kanow commented May 7, 2024 •

edited by DanielSiepmann

Loading

coveralls commented May 7, 2024 •

edited

Loading

sbuerk commented May 7, 2024

kanow commented Jul 26, 2024

oliverklee left a comment

oliverklee left a comment

lukaszuznanski commented Dec 9, 2024

kanow commented Dec 13, 2024

coveralls commented Dec 13, 2024 •

edited

Loading

[FEATURE] Add command controller to create test data #1297

[FEATURE] Add command controller to create test data #1297

Conversation

kanow commented May 7, 2024 • edited by DanielSiepmann Loading

coveralls commented May 7, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10167965078

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

sbuerk commented May 7, 2024

kanow commented Jul 26, 2024

oliverklee left a comment

Choose a reason for hiding this comment

oliverklee left a comment

Choose a reason for hiding this comment

lukaszuznanski commented Dec 9, 2024

kanow commented Dec 13, 2024

coveralls commented Dec 13, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12447292792

Details

💛 - Coveralls

kanow commented May 7, 2024 •

edited by DanielSiepmann

Loading

coveralls commented May 7, 2024 •

edited

Loading

coveralls commented Dec 13, 2024 •

edited

Loading