Use openai compatible environment variables for configuration and allow configuration using more specific variables that do not interfere with the openai defaults #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankle
reviewed
May 7, 2024
| else | ||
| messagesJson='['$(join_by , "${qaMessages[@]}")']' | ||
| fi | ||
| messagesJson='['$(join_by , "${qaMessages[@]}")']' |
There was a problem hiding this comment.
does not work for me if qaMessages is defined as above
function join_by {
local d=${1-} f=${2-}
if shift 2; then
printf %s "$f" "${@/#/$d}"
fi
}
qaMessages=()
messagesJson='['$(join_by , "${qaMessages[@]}")']'
gives "join_by:shift:2: shift count must be <= $#"
There was a problem hiding this comment.
but the above code adds an element to the array: qaMessages+=, so qaMessages cannot be empty
There was a problem hiding this comment.
sry my bad; works indeed fine with bash (butt actually I think it's great there are tests now :)
mathiasburger
force-pushed
the
feature/configuration
branch
4 times, most recently
from
d04fb92 to
61a0425
Compare
…ow configuration using more specific variables that do not interfere with the openai defaults Signed-off-by: Mathias Burger <[email protected]>
mathiasburger
force-pushed
the
feature/configuration
branch
3 times, most recently
from
32f0a16 to
33fcb1e
Compare
Signed-off-by: Mathias Burger <[email protected]>
mathiasburger
force-pushed
the
feature/configuration
branch
from
33fcb1e to
6677a13
Compare
fabiankle
approved these changes
May 9, 2024
| else | ||
| messagesJson='['$(join_by , "${qaMessages[@]}")']' | ||
| fi | ||
| messagesJson='['$(join_by , "${qaMessages[@]}")']' |
There was a problem hiding this comment.
sry my bad; works indeed fine with bash (butt actually I think it's great there are tests now :)
| - name: Install BATS | ||
| run: sudo apt-get update && sudo apt-get install -y bats | ||
| - name: Run BATS Tests | ||
| run: bats --formatter tap test |
There was a problem hiding this comment.
really cool;
If you'd like, how about adding some smoke test test/please.bats
#!/usr/bin/env bats
PLEASE_EXE=$BATS_TEST_DIRNAME/../please.sh
@test "smoke test please --help" {
result=$($PLEASE_EXE '--help')
[ "${result:0:6}" == "Please" ]
}
@test "smoke test please --version" {
result=$($PLEASE_EXE '--version')
[ "${result:0:8}" == "Please v" ]
}(just to make sure the main() is called correctly)
Signed-off-by: Mathias Burger <[email protected]>
mathiasburger
force-pushed
the
feature/configuration
branch
from
e3e9e70 to
0641366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use openai compatible environment variables for configuration and allow configuration using more specific variables that do not interfere with the openai defaults