Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(core): support asynchronous deserializers #130

Closed
wants to merge 1 commit into from

Conversation

Airblader
Copy link
Collaborator

relates #93

This is a work in progress following a quick proof of concept. Open points I need to work on:

  • Tests
  • Documentation (also explicitly mention we look at the first emission)
  • Support promises as well
  • Provide documentation on the long rxjs pipeline since this now seems necessary
  • Actually first() on the returned observable + takeUntil
  • Ensure the rxjs pipeline has proper intermediate types
  • forkJoin is currently highlighted as deprecated due to the wrong type being used; fix this

This pull request relates to or closes the following issues:

I have verified that…

  • the commits in this pull request follow the conventionalcommits pattern
  • tests have been updated or added
  • documentation has been updated to reflect the changes made

We now support deserializers which run asynchronously by returning an
observable instead. This is useful when the deserializer relies on some
asynchronous process or data which has to be fetched first.

relates #93

Signed-off-by: Ingo Bürk <[email protected]>
@Airblader Airblader closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant