replace Java 9 deprecated newInstance() with constructor.newInstance()

Signed-off-by: Andreas Schmid <[email protected]>
TNG · Jul 10, 2018 · f35c736 · f35c736
1 parent d4db3bd
commit f35c736
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/junit4/src/main/java/com/tngtech/java/junit/dataprovider/DataProviderFrameworkMethod.java b/junit4/src/main/java/com/tngtech/java/junit/dataprovider/DataProviderFrameworkMethod.java
@@ -3,6 +3,7 @@
 import static com.tngtech.java.junit.dataprovider.common.Preconditions.checkArgument;
 import static com.tngtech.java.junit.dataprovider.common.Preconditions.checkNotNull;
 
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.Arrays;
 
@@ -91,14 +92,25 @@ public String getName() {
         }
 
         try {
-            return nameFormatter.newInstance().format(getMethod(), idx, Arrays.asList(parameters));
+            return nameFormatter.getDeclaredConstructor().newInstance().format(getMethod(), idx,
+                    Arrays.asList(parameters));
         } catch (InstantiationException e) {
             throw new IllegalStateException(String
                     .format("Could not instantiate name formatter using default constructor '%s'.", nameFormatter),
                     e);
         } catch (IllegalAccessException e) {
             throw new IllegalStateException(
                     String.format("Default constructor not accessable of name formatter '%s'.", nameFormatter), e);
+        } catch (InvocationTargetException e) {
+            throw new IllegalStateException(String.format("Default constructor of name formatter '%s' has thrown: %s",
+                    nameFormatter, e.getMessage()), e);
+        } catch (NoSuchMethodException e) {
+            throw new IllegalStateException(
+                    String.format("Default constructor not found for name formatter '%s'.", nameFormatter), e);
+        } catch (Exception e) {
+            throw new IllegalStateException(String.format(
+                    "Unexpected exception while finding and invoking default constructor of name formatter '%s': %s",
+                    nameFormatter, e.getMessage()), e);
         }
     }