More easily detect overridden methods & calls to super #1040
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| package com.tngtech.archunit.core.domain; | ||
|
|
||
|
|
||
| import com.tngtech.archunit.core.importer.ClassFileImporter; | ||
| import org.junit.Test; | ||
|
|
||
| import static com.tngtech.archunit.testutil.Assertions.assertThat; | ||
|
|
||
| public class JavaMethodTest { | ||
| @Test | ||
| public void isOverriddenTest() { | ||
| class Base { | ||
| void method1() { | ||
| } | ||
|
|
||
| void method1(int x) { | ||
| } | ||
| } | ||
| class Child extends Base { | ||
| void method1() { | ||
| } | ||
|
|
||
| void method2() { | ||
| } | ||
| } | ||
| class GrandChild extends Child { | ||
| void method1() { | ||
|
|
||
| } | ||
|
|
||
| void method1(int x) { | ||
|
|
||
| } | ||
|
|
||
| void method2() { | ||
|
|
||
| } | ||
|
|
||
| void method3() { | ||
|
|
||
| } | ||
|
|
||
| } | ||
| ClassFileImporter importer = new ClassFileImporter(); | ||
| JavaClass baseClass = importer.importClass(Base.class); | ||
| JavaClass childClass = importer.importClass(Child.class); | ||
| JavaClass grandChildClass = importer.importClass(GrandChild.class); | ||
| assertThat(baseClass.getMethod("method1").isOverridden()).isFalse(); | ||
| assertThat(baseClass.getMethod("method1", int.class).isOverridden()).isFalse(); | ||
| assertThat(childClass.getMethod("method1").isOverridden()).isTrue(); | ||
| assertThat(childClass.getMethod("method2").isOverridden()).isFalse(); | ||
| assertThat(grandChildClass.getMethod("method1").isOverridden()).isTrue(); | ||
| assertThat(grandChildClass.getMethod("method1", int.class).isOverridden()).isTrue(); | ||
| assertThat(grandChildClass.getMethod("method2").isOverridden()).isTrue(); | ||
| assertThat(grandChildClass.getMethod("method3").isOverridden()).isFalse(); | ||
| //TODO add testing for methods with generic parameters | ||
|
There was a problem hiding this comment. It seems that we indeed don't recognize all overriden generic methods: @Test
public void overridden_generic_methods_are_supported() {
class Parent<T extends Number> {
void method(T t) { }
}
class Child extends Parent<Integer> {
@Override
void method(Integer t) { }
}
JavaClass childClass = new ClassFileImporter().importClass(Child.class);
JavaMethod method = childClass.getMethod("method", Integer.class);
assertThat(method.isOverridden()).isTrue(); // Expecting value to be true but was false
}There was a problem hiding this comment. Hmmm, this might complicate the code now. |
||
| } | ||
| } | ||
|
There was a problem hiding this comment. We should also have a test for the use case of #1047 . There was a problem hiding this comment. I believe that is already in place, currently we check if the parameters and name of the method are equal, and that implies compatibility of return type. There was a problem hiding this comment. I thought that we should document that this works (which it curently does, but we also want to avoid any future regression): @Test
public void more_specific_return_type_is_supported() {
class Parent {
CharSequence method() { return "base"; }
}
class Child extends Parent {
@Override
String method() { return "overridden"; }
}
JavaClass childClass = new ClassFileImporter().importClass(Child.class);
JavaMethod method = childClass.getMethod("method");
assertThat(method.isOverridden()).isTrue();
} |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pleae add a small test to cover the feature that overriden methods from interfaces are detected?