Adding a warning next to the Workflow selector if the Workflow requires high VRAM. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschuettlerTNG
requested changes
Jan 13, 2025
| <p>Workflow</p> | ||
| <div class="flex justify-between items-center pt-3"> | ||
| <p>Workflow</p> | ||
| <p v-show="imageGeneration.activeWorkflow.requirements?.includes('high-vram')" data-tooltip="This model requires a lot of VRAM. Reduce the resolution and/or restart the ComfyUI backend when in case you experience a poor performance."> ⚠️ high VRAM ⚠️</p> |
There was a problem hiding this comment.
Please make the text translatable.
Regarding the notice itself:
- It is not clear that the user is able to hover to get more info. Maybe add a dashed underline?
- It is not clear what high VRAM is referring to, maybe "High VRAM req."?
- I think one
⚠️ is enough :) Ideally, this would also be an icon in the same style as other UI elements (see icons directly below)
There was a problem hiding this comment.
there is no warning sign in src/assets/svg. Since I am unsure regarding licences, do you know what is best to use?
There was a problem hiding this comment.
I made the text translatable, however, I am not entirely happy on how I implemented the infos displayed after hoovering (although it works). If you see a better solution, I would be interested to hear.
julianbollig
force-pushed
the
AddVramWarning
branch
from
d2226b4 to
0e25094
Compare
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
mschuettlerTNG
force-pushed
the
AddVramWarning
branch
from
0e25094 to
67f94ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.