Feature/licences for workflow in download dialog full #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianesser-tng
force-pushed
the
feature/licencesForWorkflowInDownloadDialog_full
branch
from
4779013 to
72f0915
Compare
some workflows may fetch models from different places (e.g. from within the logic of the node itself) these models may still be bound to explicit approval by customer, which we prompt by the download dialog Ideally, we would need to merge the downloading dialog of the models with the downloading of the custom node But we do not have the time. Signed-off-by: Florian Esser <[email protected]>
Pass value of licence link through complete chain Ideally, operations should be itemwise, not listwise, then I would not require this quickfix of passing it throught he complete chain. But there is unfortunately no time Signed-off-by: Florian Esser <[email protected]>
They introduce too much hastle to deal with and are too risky for the release. We are capturing user consent via the other loaded modles." Signed-off-by: Florian Esser <[email protected]>
Addition of transitive comfyUI-node model downloads requires additional UI elements. Signed-off-by: marijnvg-tng <[email protected]>
SetupProgressListener were not correctly resetted Setup function of comfyUI backend was broken after lsLevelZeroExe Call optimations Listen to comfyServerState == running instead of isSetup Signed-off-by: Florian Esser <[email protected]>
uv no longer part of python env
florianesser-tng
force-pushed
the
feature/licencesForWorkflowInDownloadDialog_full
branch
from
e7a78ec to
6f08ac0
Compare
git rev parse failed due to windows 5 error. Hence, be a little more forgiving on reading it Safeguard disable/enable calls to backend. Due to the v-ifs being exchanged with v-shows, at startup time we now call these functions and they might fail. A reject at this time leads to the app being locked. Signed-off-by: Florian Esser <[email protected]>
mschuettlerTNG
deleted the
feature/licencesForWorkflowInDownloadDialog_full
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please provide a brief description of the changes made in this pull request.
Related Issue:
If this pull request is related to any existing issue, please mention the issue number here.
Changes Made:
Please list down the specific changes made in this pull request.
Testing Done:
Please describe the testing that has been done to ensure the changes made in this pull request are functioning as expected.
Screenshots:
If applicable, please provide screenshots or GIFs or videos to visually demonstrate the changes made.
Checklist: