Feat/26 llm download from dropdown backup #3
Conversation
marijnvg-tng
force-pushed
the
Feat/26--LLM_download_from_dropdown_backup
branch
from
9777bf9 to
ecfa517
Compare
| <learn-more v-show="activeTabIdx == 3"></learn-more> | ||
| <app-settings v-if="showSetting" @close="hideAppSettings" @show-download-model-confirm="showDownloadModelConfirm"></app-settings> | ||
| </div> | ||
| <download-dialog v-show="showDowloadDlg" ref="downloadDigCompt" @close="showDowloadDlg = false"></download-dialog> | ||
| <add-l-l-m-dialog v-show="showModelRequestDialog" ref="addLLMCompt" @close="showModelRequestDialog = false" @call-check-model="callCheckModel" @show-warning="showWarning"></add-l-l-m-dialog> | ||
| <warning-dialog v-show="showWarningDialog" ref="warningCompt" @close="showWarningDialog = false"></warning-dialog> |
There was a problem hiding this comment.
I am not yet convinced, that the llmDialog and the warning dialog should be on this level. My feeling is: keep app.vue as slim as possible, otherwise we will not be able to mentally control it in the long run. We already have some "noise" of events, that simply flip booleans to display some popup/dialogs.
my gut feeling: introduce the add$ModelType as a component on its own , where type is probably (on the long run) corresponding to the view $answer/create/enhance -> llm/stablediff/??? . Probably, in considering the correct hierarchies, one arrives at a cleaner communication between components overall, especially when it comes to delegating events to the download component.
I would also be willing with this design for now and get feedback of intel. But imo we need to be very careful in not letting this degrade.
I am however happy to hear, if you spent thoughts on this
julianbollig
force-pushed
the
Feat/26--LLM_download_from_dropdown_backup
branch
from
160f92a to
8ad22a0
Compare
marijnvg-tng
force-pushed
the
Feat/26--LLM_download_from_dropdown_backup
branch
from
8ad22a0 to
4d04de6
Compare
…ad panel still missing Signed-off-by: julianbollig <[email protected]>
… panel. Signed-off-by: marijnvg-tng <[email protected]>
Signed-off-by: marijnvg-tng <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: julianbollig <[email protected]>
Signed-off-by: marijnvg-tng <[email protected]>
Signed-off-by: marijnvg-tng <[email protected]>
Signed-off-by: marijnvg-tng <[email protected]>
Signed-off-by: julianbollig <[email protected]>
marijnvg-tng
force-pushed
the
Feat/26--LLM_download_from_dropdown_backup
branch
from
4d04de6 to
c617ce0
Compare
Signed-off-by: Markus Schuettler <[email protected]>
mschuettlerTNG
force-pushed
the
Feat/26--LLM_download_from_dropdown_backup
branch
from
89e02e8 to
2916814
Compare
mschuettlerTNG
deleted the
Feat/26--LLM_download_from_dropdown_backup
branch
No description provided.