Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

메인 화면 figma 프로토 타입 초기 퍼블리싱 / 컴포넌트 구조 설계 작업 #6

Merged
merged 12 commits into from
Nov 5, 2024

Conversation

GHooN99
Copy link
Contributor

@GHooN99 GHooN99 commented Nov 1, 2024

작업 내용 요약

image

전반적인 피그마 프로토 타입 퍼블리싱 , 레이아웃 , 컴포넌트 구조 잡기 작업

  • 시계 기능 + (문구 로드 기능)
  • 배경 이미지 로드 기능
  • 검색창 , 실검 리스트 퍼블리싱
  • 학사공지 퍼블리싱
  • 북마크 퍼블리싱
  • overlay-kit , 폰트 설정도 추가

임시로 배포 해둠

참고자료

  • 피그마 프로토 타입

image

@GHooN99 GHooN99 requested a review from Anhye0n November 1, 2024 13:05
@GHooN99 GHooN99 self-assigned this Nov 1, 2024
Copy link
Contributor

@Anhye0n Anhye0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
<title>세모 - 세종대의 모든 것</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title 깔끔하게 잘 설정된 것 같아요!

@@ -30,6 +30,7 @@
"@tanstack/react-query-devtools": "^5.59.8",
"axios": "^1.7.7",
"jotai": "^2.10.0",
"overlay-kit": "^1.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번에 처음 알게되었습니다. 덕분에 좋은 것 하나 배웁니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 불러오는 기능 분리 좋은 것 같아요.

Comment on lines +14 to +22
fetchImageWithFallback({
imageUrl,
onSuccess: () => setIsImageReady(true),
onError: () => {
setBackgroundImageUrl(FALLBACK_BACKGROUND_URL);
setIsImageReady(true);
},
});
}, []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Comment on lines +3 to +5
export const SearchInput = () => {
return <StyledInput type='text' placeholder='무엇이든 검색해 보세요...' />;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 검색 엔진 느낌으로 개발 진행하겠습니다!

Comment on lines +13 to +43
export const Home = () => {
return (
<AppContainer>
<BackgroundImageView />
<HeaderView />
<Clock />

{/* Search */}
<SearchInputContainer>
<SearchInput />
<TrendingKeywords />
</SearchInputContainer>

{/* <Notice /> */}
<NoticeView />

{/* <Bookmark /> */}
<BookmarkContainer>
<BookmarkCard />
<BookmarkCard />
<BookmarkCard />
<BookmarkCard />
<BookmarkCard />
<BookmarkCard />
</BookmarkContainer>

{/* 여기까지 스크롤 전 */}
{/* <ProjectCuration /> */}
</AppContainer>
);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한눈에 잘 보이는 것 같아요!

@Anhye0n Anhye0n merged commit 10ad51b into develop Nov 5, 2024
4 checks passed
@GHooN99 GHooN99 deleted the feature/layout branch November 10, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants