Fix error message display in the spec report

.github/actions/specs-report/__tests__/summary-report.test.ts

@@ -0,0 +1,52 @@
+import * as core from '@actions/core'
+import { TestVector, TestVectorReport } from '../src/test-vectors'
+import { generateSummary } from '../src/summary-report'
+
+describe('summary-report', () => {
+  it('should display the error message in the markdown table properly', () => {
+    jest.spyOn(core.summary, 'write').mockImplementation()
+
+    const tbdexKtErrorSample: TestVector = {
+      feature: 'Protocol',
+      name: 'parse_rfq',
+      file: '/home/runner/work/tbdex-kt/tbdex-kt/tbdex/hosted/test-vectors/protocol/vectors/parse-rfq.json',
+      testCases: [
+        {
+          name: 'parse_rfq',
+          classname: 'tbdex.sdk.protocol.TbdexTestVectorsProtocol',
+          time: 13.913,
+          error: [
+            {
+              inner:
+                'java.lang.IllegalStateException: Verification failed. Failed to resolve kid. Error: internalError\n\tat web5.sdk.jose.jws.DecodedJws.verify(Jws.kt:262)\n\tat tbdex.sdk.protocol.SignatureVerifier.verify(SignatureVerifier.kt:60)\n\tat tbdex.sdk.protocol.models.Message.verify(Message.kt:82)\n\tat tbdex.sdk.protocol.Parser.parseMessage(Parser.kt:45)\n\tat tbdex.sdk.protocol.TbdexTestVectorsProtocol.parse_rfq(TbdexTestVectorsProtocol.kt:145)\n\tat java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat java.base/jdk.internal.reflect....\n',
+              message:
+                'Verification failed. Failed to resolve kid. Error: internalError',
+              type: 'java.lang.IllegalStateException'
+            }
+          ],
+          'system-err': [
+            'SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".\nSLF4J: Defaulting to no-operation (NOP) logger implementation\nSLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.\n'
+          ]
+        }
+      ]
+    }
+
+    const report: TestVectorReport = {
+      totalJunitFiles: 0,
+      totalTestVectors: 1,
+      totalJunitTestCases: 1,
+      specTestCases: 1,
+      specFailedTestCases: 1,
+      specPassedTestCases: 0,
+      specSkippedTestCases: 0,
+      missingVectors: [],
+      failedVectors: [tbdexKtErrorSample],
+      skippedVectors: [],
+      successVectors: []
+    }
+
+    const summary = generateSummary(report)
+
+    expect(summary).toContain('Failed to resolve kid.')
+  })
+})

.github/actions/specs-report/src/summary-report.ts

@@ -93,10 +93,10 @@ const addFailedVectorsSection = (
         { data: 'Failure Message', header: true }
       ]
       const failedTestsRows = vector.testCases
-        .filter(testCase => testCase.failure)
+        .filter(testCase => testCase.failure || testCase.error)
         .map(testCase => [
           testCase.name ?? 'Unnamed test',
-          failureToMessageRows(testCase.failure ?? [])
+          failureToMessageRows(testCase.error ?? testCase.failure ?? [])
         ])
       core.summary.addTable([failedTestsHeaderRow, ...failedTestsRows])
     }
@@ -175,9 +175,10 @@ const failureToMessageRows = (
         .replace(/>/g, '>')
         .replace(/"/g, '"')
         .replace(/'/g, ''')
+        .substring(0, 128)
       return `<b>${detail.message}</b><br/><pre>${
         escapedInnerHTML || 'Unknown error'
-      }\n</pre>`
+      }...\n</pre>`
     })
     .join('<br>\n')
 }