Enhance "sources" information with NtpData response #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
Jan 7, 2025
Can you open an issue about this? I am unable to reproduce this, running with |
rbott
force-pushed
the
add_ntpdata_details
branch
2 times, most recently
from
d48359c to
74800d0
Compare
|
I have rebased this PR against the |
SuperQ
reviewed
Jan 8, 2025
SuperQ
requested changes
Jan 8, 2025
|
A couple of minor nits, otherwise looks great. |
This commit extends the "sources" information with additional peer/source information from the NtpData response. Namely it adds: - Offset - Peer Delay - Peer Dispersion - Peer Response Time - Peer Jitter Asymmetry The additional data collection is hidden behind a new flag `--collector.sources-with-ntpdata` which defaults to `false` Signed-off-by: Rudolph Bott <[email protected]>
rbott
force-pushed
the
add_ntpdata_details
branch
from
74800d0 to
485bc99
Compare
|
Both nits have been addressed, thanks for reviewing so quickly :-) |
SuperQ
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to extend source information with some peer details which can be retrieved via the
NtpDataresource.This PR extends the "sources" information with additional peer/source information from the NtpData response. Namely it adds:
What do you think about the implementation? Since the current
mainbuild does not work (crashes with logging issues when set todebuglog level) we developed/tested this against the latest release tag.