BUG: ParameterObject::WriteParameterFiles should write all maps
#967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
approved these changes
Sep 28, 2023
| // Check that each of the specified files is written to disk. | ||
| for (const auto & fileName : fileNames) | ||
| { | ||
| EXPECT_TRUE(itksys::SystemTools::FileExists(fileName.c_str(), true)); |
There was a problem hiding this comment.
Did elastix switch to C++17 yet? If so, std::filesystem::exists could be used here.
There was a problem hiding this comment.
Thanks for asking! The elastix main branch has switched to C++17, but I'm still reluctant to use std::filesystem, because ITK does not yet use std::filesystem either. As we discussed at https://discourse.itk.org/t/shall-we-start-using-c-17-at-the-master-branch/5828, March 2023. (std::filesystem would require at least GCC version 8). Of course I'm glad to hear if it's OK by now for ITK to require at least GCC 8. 😃
Aims to fix macos-11/clang errors saying "error: use of undeclared identifier 'elx'".
With this commit `ParameterObject::WriteParameterFiles` writes _each_ maps to a file, including the first one. Aims to address issue #904 "ParameterObject::WriteParameterFiles does not write the first map!" A GoogleTest unit test is added, testing that each of the files specified by the `parameterFileNameVector` parameter is indeed written to disk.
N-Dekker
force-pushed
the
ParameterObject-WriteParameterFiles-write-all-maps
branch
from
2ee1c33 to
d315d64
Compare
N-Dekker
deleted the
ParameterObject-WriteParameterFiles-write-all-maps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit
ParameterObject::WriteParameterFileswrites each maps to a file, including the first one. Aims to address issue #904 "ParameterObject::WriteParameterFiles does not write the first map!"A GoogleTest unit test is added, testing that each of the files specified by the
parameterFileNameVectorparameter is indeed written to disk.