COMP: Add missing semicolons to ITK macro calls #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to resolve issue #1224 "Missing semicolons causing compile issues with some compilers". ITK has become stricter with respect to those semicolons from ITK pull request InsightSoftwareConsortium/ITK#4706 commit InsightSoftwareConsortium/ITK@55e2339 "ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT", Hans Johnson, June 4, 2024. Co-authored-by: Wildcarde <[email protected]>
|
@Wildcarde Is it OK that I mentioned you as co-author of the commit? |
N-Dekker
commented
Aug 30, 2024
Comment on lines
-114
to
+123
| itkSetMacro(GradientMagnitudeTolerance, double) | ||
|
|
||
| /** Setting: a stopping criterion, the value tolerance. By default 1e-5. | ||
| * | ||
| * The optimizer stops when | ||
| * \f[ 2.0 * | f_k - f_{k-1} | \le | ||
| * ValueTolerance * ( |f_k| + |f_{k-1}| + 1e-20 ) \f] | ||
| * is satisfied MaxNrOfItWithoutImprovement times in a row. | ||
| */ | ||
| itkGetConstMacro(ValueTolerance, double); | ||
| itkSetMacro(GradientMagnitudeTolerance, double); | ||
|
|
||
| /** Setting: a stopping criterion, the value tolerance. By default 1e-5. | ||
| * | ||
| * The optimizer stops when | ||
| * \f[ 2.0 * | f_k - f_{k-1} | \le | ||
| * ValueTolerance * ( |f_k| + |f_{k-1}| + 1e-20 ) \f] | ||
| * is satisfied MaxNrOfItWithoutImprovement times in a row. | ||
| */ | ||
| itkGetConstMacro(ValueTolerance, double); |
There was a problem hiding this comment.
@Wildcarde FYI, I only just applied your patch, but then the automatic source code formatting (clang-format) also made some adjustments, as you see here!
yep not a problem at all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve issue #1224 "Missing semicolons causing compile issues with some compilers".
ITK has become stricter with respect to those semicolons from ITK pull request InsightSoftwareConsortium/ITK#4706 commit InsightSoftwareConsortium/ITK@55e2339 "ENH: Default to allow ITK_MACROEND_NOOP_STATEMENT", Hans Johnson, June 4, 2024.