-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SEP-5 tests for Shamir, more documentation and examples #1015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only a few details may be worth revising, and I have placed them in the comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 261 261
Lines 14066 14075 +9
=======================================
+ Hits 13813 13822 +9
Misses 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusting for entropy instead of BIP-39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this excellent PR! The code is clean and well-documented.
But I noticed that one test case failed; can you update it? Once the tests pass, we can merge it.
Done 😃 |
Oh wait there is something fishy. |
ok I had to revert the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow up of #1012
(Note I will link the PR to the SEP-5 itself once I put it up.)
EDIT this is the update to the SEP stellar/stellar-protocol#1601