Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase verbosity, fix black-hole startup, try to restore LD_LIBRARY_PATH for startup_script #3

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

Sntx626
Copy link
Contributor

@Sntx626 Sntx626 commented Sep 4, 2024

No description provided.

@technobaboo
Copy link
Contributor

is this tested and working?

@Sntx626 Sntx626 marked this pull request as draft September 4, 2024 12:16
@Sntx626
Copy link
Contributor Author

Sntx626 commented Sep 4, 2024

Well...

I converted it back to a draft.
black-hole seems to be borked: starting it with black-hole causes an animation on interacting with the launcher but closes it immediately.

The logging and env var migration seems to works.
(I set a fake LD_LIBRARY_PATH, since it is not set natively on my machine)

Test by running:

LD_LIBRARY_PATH=/test nix run --impure

@Sntx626
Copy link
Contributor Author

Sntx626 commented Sep 4, 2024

I build it before opening the PR, it did not interact with it much...
My bad.

@technobaboo
Copy link
Contributor

i'll be honest... it might just be better to get the newer setup i have working where i have a script and CI manually build the appimage in an appdir then package it up.... wanna talk about it in discord?

@Sntx626 Sntx626 marked this pull request as ready for review September 9, 2024 19:33
@Sntx626
Copy link
Contributor Author

Sntx626 commented Sep 9, 2024

This PR works!

Though "fixing" black-hole makes it hard to impossible to launch the hexagon-launcher in 2d mode. Since you only interact with black hole instead.

@technobaboo technobaboo merged commit 0759d19 into StardustXR:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants