-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix re-rendering issue when connecting for the first time #180
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for sporosdaoapp-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
I'll fix up tests once we discuss this direction, using the web3context like this. LMK what you think! |
@@ -0,0 +1,4 @@ | |||
# Disable React Host Check in Dev Mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember adding this and don't have it locally? not sure how it ended up here.
@briareus-the-titan I see you requested review, but there are failing checks still. Do you mind switching to draft PR until all checks pass. |
PR should close #177
Description
If you connect your wallet for the first time, nothing happens. This was because react wasn't re-rendering after wagmi and rainbows initial connect.
I've also added a rule to eslint that should be helpful. LMK if you don't like that and I'll remove it
https://www.loom.com/share/fe78d31f5ca847dbbe83333ab7375ef5