Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error 502 that is thrown for analysis errors #285

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Catch error 502 that is thrown for analysis errors #285

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f20d9c8
Catch error 502 that is thrown for analysis errors
sbrinkhorst Aug 16, 2023
84ff4bd
Fix test
sbrinkhorst Aug 16, 2023
d016a74
Clarify error message
sbrinkhorst Aug 16, 2023
9eaddda
Clarify message (again)
sbrinkhorst Aug 29, 2023
a08e276
Merge branch 'main' into sbrinkhorst-patch-2
sbrinkhorst Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sigridci/sigridci/sigrid_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def retry(self, operation, *, attempts=5, allow404=False, allowEmpty=True):
else:
UploadLog.log(f"The system no longer exists (HTTP status {e.code})")
sys.exit(1)
elif e.code == 502:
UploadLog.log("Something went wrong during analysis on our end (possibly related to configuration issues)")
sys.exit(1)
elif allow404 and e.code == 404:
return False

Expand Down
2 changes: 1 addition & 1 deletion test/test_repository_history_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ def testExportGitHistory(self):
historyEntries = f.read().strip().split("\n")

self.assertEquals(historyEntries[0],
"'@@@;3e161af9218e6f20a095a96ee246763e9c01f1e3;Thomas Kraus (tukraus);thomas@sig.nl;2016-05-24 09:25:40 +0200;remove javascript'")
"'@@@;f59c21c9de5bee332d51cea5caef4b2500ea100e;Michiel Cuijpers;m.cuijpers@sig.eu;2023-08-15 13:57:07 +0200;Create sigrid-publish.yml'")