Addresses #8093 by using proper placeholder for bed temperature #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original setting was using `hot_plate_temp_initial_layer` which doesn't respect the various build plate temperatures. `bed_temperature_initial_layer_single` does.
|
Not sure how my changes would cause the errors listed in the tests so I'm assuming they came in as part of that merge from main. If there's something I need to do to fix this, let me know and I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #8093 by using proper placeholder for bed temperature. The original setting was using
hot_plate_temp_initial_layerwhich doesn't respect the various build plate temperatures. The updated placeholderbed_temperature_initial_layer_singledoes.Screenshots/Recordings/Graphs
N/A
Tests
Multiple prints of different filament types all use the correct bed temperatures defined in their profiles.