Fixes for espruino#2589 I2C1 and I2C2 pin defaults in ESP32.py and Re…

…vert Debug =1 for build action workflow testing,
SimonGAndrews · Jan 19, 2025 · f50ed22 · f50ed22
1 parent 14119c7
commit f50ed22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -49,7 +49,7 @@ jobs:
     - name: make ${{ matrix.board }}
       env:
         TRAVIS: 1
-        DEBUG: 1
+        RELEASE: 1
         BOARD: ${{ matrix.board }} 
         UPLOADTOKEN: ${{ secrets.UPLOADTOKEN }}  
       run: |

diff --git a/boards/ESP32.py b/boards/ESP32.py
@@ -188,9 +188,11 @@ def get_pins():
   pinutils.findpin(pins, "PD32", True)["functions"]["USART1_RX"]=0; # doesn't match jshardwareUart?
   pinutils.findpin(pins, "PD16", True)["functions"]["USART3_RX"]=0;
   pinutils.findpin(pins, "PD17", True)["functions"]["USART3_TX"]=0; 
+  pinutils.findpin(pins, "PD16", True)["functions"]["I2C2_SCL"]=1;  # added for issue #2589 fix
+  pinutils.findpin(pins, "PD17", True)["functions"]["I2C2_SDA"]=1;  # added for issue #2589 fix
 
-  pinutils.findpin(pins, "PD21", True)["functions"]["I2C1_SCL"]=0;
-  pinutils.findpin(pins, "PD22", True)["functions"]["I2C1_SDA"]=0;
+  pinutils.findpin(pins, "PD22", True)["functions"]["I2C1_SCL"]=0; # SCL moved from P21 for issue #2589
+  pinutils.findpin(pins, "PD21", True)["functions"]["I2C1_SDA"]=0; # SDA moved from P22 for issue #2589
   pinutils.findpin(pins, "PD14", True)["functions"]["SPI1_SCLK"]=0;
   pinutils.findpin(pins, "PD12", True)["functions"]["SPI1_MISO"]=0;
   pinutils.findpin(pins, "PD13", True)["functions"]["SPI1_MOSI"]=0;