Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally render Intercom script in EJS based on APP_ID #6777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seuros
Copy link

@seuros seuros commented Jan 8, 2025

Added EJS conditional logic to render the Intercom script tag only if INTERCOM_APP_ID is defined


Important

Conditionally renders Intercom script in index.html.ejs based on INTERCOM_APP_ID.

  • Behavior:
    • Conditionally renders Intercom script in index.html.ejs only if INTERCOM_APP_ID is defined.
    • Prevents loading Intercom script when INTERCOM_APP_ID is not set.

This description was created by Ellipsis for 4fdaaf2. It will automatically update as commits are pushed.

- Added EJS conditional logic to render the Intercom script tag only if INTERCOM_APP_ID is defined
@seuros seuros requested a review from YounixM as a code owner January 8, 2025 15:53
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4fdaaf2 in 15 seconds

More details
  • Looked at 94 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/index.html.ejs:62
  • Draft comment:
    The indentation of the EJS conditional block is inconsistent. Consider aligning it with the rest of the HTML structure for better readability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The indentation of the EJS conditional block is inconsistent with the rest of the file.
2. frontend/src/index.html.ejs:62
  • Draft comment:
    Avoid using inline styles in HTML. Consider using external stylesheets or CSS classes instead. This applies to the entire script block.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR does not violate any of the specified rules. The changes are related to conditional rendering of a script based on a variable, which is appropriate for the context.

Workflow ID: wflow_2EWc9BOX51dN4HQJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant