chore: fix cookie vulnerability #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0fff4e9 in 18 seconds
More details
- Looked at
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/package.json:249
- Draft comment:
Ensure the 'cookie' package is used in the codebase to address the vulnerability mentioned in the PR title. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the 'cookie' package in both dependencies and resolutions is consistent, but it's important to ensure that the package is actually used in the codebase to address the vulnerability mentioned in the PR title.
2. frontend/package.json:249
- Draft comment:
Ensure that the addition of the 'cookie' package is necessary and relevant to the current changes. If it's unrelated to the ClickHouseReader interface or design token usage, consider removing it. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the 'cookie' package seems unrelated to the ClickHouseReader interface or any design token usage.
Workflow ID: wflow_gCJW6jSfZEw6Blm5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
approved these changes
Jan 8, 2025
amlannandy
pushed a commit
that referenced
this pull request
Jan 16, 2025
amlannandy
pushed a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
https://github.com/SigNoz/signoz/security/dependabot/183
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add
cookiepackage topackage.jsonto address cookie vulnerability.cookiepackage version^0.7.1todependenciesinpackage.json.This description was created by
for 0fff4e9. It will automatically update as commits are pushed.