feat: aws integration: UI facing QS api for cloud account management #6771
+1,187
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-0
branch
2 times, most recently
from
202bc43 to
7d576aa
Compare
…enerate-connection-url
…get account status
…getting account status
… in list of connected accounts
…t list after agent check in
…ig after account config update
…n of connection url
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-0
branch
from
7d576aa to
5e1246b
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5e1246b in 1 minute and 53 seconds
More details
- Looked at
1390lines of code in11files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. pkg/query-service/utils/testutils.go:19
- Draft comment:
Consider checking the error returned byos.Removein the cleanup function to ensure the temporary file is successfully deleted. This will help avoid leftover files in the system. - Reason this comment was not posted:
Confidence changes required:50%
The functionNewTestSqliteDBcreates a temporary SQLite database for testing purposes. However, it does not handle the case where the temporary file cannot be removed during cleanup. This could lead to leftover files in the system.
2. pkg/query-service/utils/testutils.go:33
- Draft comment:
The TODO comment suggests that passing the DB file path should not be necessary. Consider refactoring the code to eliminate the need for passing the DB file path todao.InitDaoanddashboards.InitDB. - Reason this comment was not posted:
Confidence changes required:50%
TheNewQueryServiceDBForTestsfunction initializes the DAO and dashboards with the test database file path. However, the TODO comment suggests that passing the DB file path should not be necessary. This indicates a potential area for improvement in the codebase.
3. pkg/query-service/app/cloudintegrations/controller.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Comment was on unchanged code.
4. pkg/query-service/app/cloudintegrations/repo.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
5. pkg/query-service/app/cloudintegrations/model.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
6. pkg/query-service/app/cloudintegrations/controller_test.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_wjestgZYRSegDlj2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
reviewed
Jan 9, 2025
Comment on lines
+136
to
+138
| cloud_provider=? | ||
| and id in (%s)`, | ||
| strings.Join(idPlaceholders, ", "), |
There was a problem hiding this comment.
Can this be used https://jmoiron.github.io/sqlx/#inQueries?
| return nil, model.WrapApiError(apiErr, "couldn't upsert cloud account") | ||
| } | ||
|
|
||
| // TODO(Raj): Add actual cloudformation template for AWS integration after it has been shipped. |
There was a problem hiding this comment.
Just to follow, can you help me understand what does this template do? Does it setup the base or does it do anything with the AWS services?
| aH.Respond(w, resp) | ||
| } | ||
|
|
||
| func (aH *APIHandler) CloudIntegrationsAgentCheckIn( |
There was a problem hiding this comment.
I couldn't find info related to this. Can you share the flow for this? Is it going to be some agent running in cloud provider that invokes this endpoint?
| ).Methods(http.MethodPost) | ||
|
|
||
| subRouter.HandleFunc( | ||
| "/{cloudProvider}/accounts/{accountId}/disconnect", am.EditAccess(aH.CloudIntegrationsDisconnectAccount), |
There was a problem hiding this comment.
If I want to reconnect, is it going to be simple toggle, or do I have to start from beginning again?
| } | ||
|
|
||
| tsNow := time.Now() | ||
| account, apiErr := c.repo.upsert( |
There was a problem hiding this comment.
For delete, wouldn't it make more sense to throw error if account doesn't exist rather than upsert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Query Service APIs for powering AWS integrations UI
Related Issues / PR's
Contributes to #6544
Important
Adds AWS cloud account management API to Query Service with lifecycle operations and integration tests.
CloudIntegrationsControllerincloudintegrations/controller.gofor managing AWS cloud accounts.http_handler.gofor generating connection URLs, listing accounts, checking account status, updating config, and disconnecting accounts.cloudintegrations/repo.go.AccountRecordand related models incloudintegrations/model.go.signoz_cloud_integrations_test.goto validate AWS account lifecycle operations.server.goto initializeCloudIntegrationsControllerand register routes.This description was created by
for 5e1246b. It will automatically update as commits are pushed.