Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return if data is fetching #6765

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Jan 7, 2025

Important

Add check for isFetchingDeploymentsData in useEffect in CustomDomainSettings.tsx to prevent execution during data fetching.

  • Behavior:
    • Adds a check for isFetchingDeploymentsData in useEffect in CustomDomainSettings.tsx to prevent execution when data is fetching.
    • Updates dependencies of useEffect to include isFetchingDeploymentsData.

This description was created by Ellipsis for c25f182. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Jan 7, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added enhancement New feature or request docs required labels Jan 7, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c25f182 in 11 seconds

More details
  • Looked at 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/CustomDomainSettings/CustomDomainSettings.tsx:109
  • Draft comment:
    Consider adding setHosts and setCustomDomainDetails to the dependency array of the useEffect hook to ensure all dependencies are covered.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The useEffect hook is missing a dependency for setHosts and setCustomDomainDetails. These functions are used within the effect, and while they are stable in this context, it's a good practice to include them in the dependency array to avoid potential issues in the future if they change.

Workflow ID: wflow_D3ESNrDNHIDlAJSN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 7, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

request-info bot commented Jan 7, 2025

We would appreciate it if you could provide us with more info about this issue/pr!

@YounixM YounixM changed the title feat: return is data is fetching feat: return if data is fetching Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 5c546e8 into main Jan 7, 2025
17 of 24 checks passed
@YounixM YounixM deleted the feat/custom-domain-polling branch January 7, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants