-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable billing and org-settings in workspace blocked state #6761
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 683beab in 20 seconds
More details
- Looked at
18
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/AppRoutes/Private.tsx:113
- Draft comment:
Avoid usingany
type forroute
parameter. Define a specific type/interface forroute
to ensure it has the expected structure. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_SQR7wH2dMnlVx2zF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
We would appreciate it if you could provide us with more info about this issue/pr! |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on dc89503 in 1 minute and 16 seconds
More details
- Looked at
298
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
9
drafted comments based on config settings.
1. frontend/src/AppRoutes/Private.tsx:41
- Draft comment:
TheisAdmin
variable is defined but not used. Consider removing it to clean up the code. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/container/SideNav/NavItem/NavItem.tsx:28
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
3. frontend/src/container/SideNav/SideNav.tsx:378
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
4. frontend/src/container/SideNav/SideNav.tsx:394
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
5. frontend/src/container/SideNav/SideNav.tsx:404
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
6. frontend/src/container/SideNav/SideNav.tsx:415
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
7. frontend/src/container/SideNav/SideNav.tsx:432
- Draft comment:
TheisDisabled
prop is used correctly to prevent navigation when the workspace is blocked. Ensure this is consistently applied across all navigation items. - Reason this comment was not posted:
Confidence changes required:20%
TheisDisabled
prop is used in multiple places to disable navigation items when the workspace is blocked. This is a good practice to prevent user actions that are not allowed in the current state.
8. frontend/src/container/SideNav/NavItem/NavItem.styles.scss:20
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values like#3f5ecc
to maintain consistency in design and theming. This applies to other hardcoded colors in this file as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
9. frontend/src/pages/WorkspaceLocked/WorkspaceLocked.styles.scss:54
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values likevar(--text-vanilla-400)
to maintain consistency in design and theming. This applies to other hardcoded colors in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_HhSCPUisLSlwhbwd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
dc89503
to
d7cf0af
Compare
Fixes - https://github.com/SigNoz/engineering-pod/issues/1991
Important
Enable billing and organization settings access for admins in workspace blocked state, with UI updates for disabled elements.
ORG_SETTINGS
,BILLING
, andMY_SETTINGS
routes in workspace blocked state inPrivate.tsx
.navigateToWorkSpaceBlocked
to check for admin role and specific routes.isDisabled
prop toNavItem
inNavItem.tsx
to handle disabled state.SideNav.tsx
to disable menu items when workspace is blocked, except for billing and settings for admins.View Billing
button for admins inWorkspaceLocked.tsx
..disabled
class styling inNavItem.styles.scss
to indicate disabled state visually.WorkspaceLocked.styles.scss
for button styling in blocked state.This description was created by for dc89503. It will automatically update as commits are pushed.