Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support updating subdomain for tenants #6745

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Jan 3, 2025

Summary

https://www.loom.com/share/ef92e504cf494ca7a6b8402aed666b34?sid=ac45b035-d4db-447b-adab-42930f74175c


Important

Add support for updating tenant subdomains with new API endpoints, UI components, and route configurations.

  • Feature:
    • Add CustomDomainSettings component in CustomDomainSettings.tsx for managing tenant subdomains.
    • Introduce updateSubDomainAPI in updateSubDomain.ts for updating subdomains.
    • Add getDeploymentsData in getDeploymentsData.ts to fetch deployment data.
  • Routes:
    • Add CUSTOM_DOMAIN_SETTINGS route in routes.ts and constants/routes.ts.
    • Update pageComponents.ts to include CustomDomainSettings.
  • Permissions:
    • Restrict CUSTOM_DOMAIN_SETTINGS route to ADMIN in utils/permission/index.ts.
  • UI:
    • Add styles in CustomDomainSettings.styles.scss for the new component.
    • Update Breadcrumbs and DateTimeSelectionV2/config.ts to include new route.
  • Localization:
    • Add custom_domain_settings entries in locales/en-GB/routes.json and locales/en-GB/titles.json.

This description was created by Ellipsis for 2082ba7. It will automatically update as commits are pushed.

Copy link

github-actions bot commented Jan 3, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to f82e6de in 1 minute and 25 seconds

More details
  • Looked at 916 lines of code in 19 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/CustomDomainSettings/CustomDomainSettings.tsx:97
  • Draft comment:
    Consider defining the polling interval as a constant or making it configurable for better readability and maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The useEffect hook in CustomDomainSettings.tsx is responsible for polling the deployments data until the state becomes 'HEALTHY'. However, the polling interval is hardcoded to 3000 milliseconds. It would be better to define this interval as a constant or make it configurable, which would improve code readability and maintainability.
2. frontend/src/container/CustomDomainSettings/CustomDomainSettings.tsx:129
  • Draft comment:
    Ensure dns is defined before constructing the URL to avoid copying an incorrect URL.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_qEkNWZcnrvN7RaeE


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 17225b0 in 18 seconds

More details
  • Looked at 39 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/Settings/utils.ts:24
  • Draft comment:
    Consider adding a comment to explain the logic behind isCloudAccount && !isGatewayEnabled condition, as it might not be immediately clear why ingestion settings are only pushed in this scenario.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The refactoring of user role checks is a good practice for readability and maintainability. However, the logic for isCloudAccount && !isGatewayEnabled is not explained in the PR description, and it might be worth checking if this is intended behavior.

Workflow ID: wflow_f2hJvma9He2INthX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 3, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM force-pushed the feat/custom-domain branch from 819ffd7 to 2082ba7 Compare January 4, 2025 08:29
@YounixM YounixM enabled auto-merge (squash) January 4, 2025 08:29
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2082ba7 in 11 seconds

More details
  • Looked at 39 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/Settings/utils.ts:50
  • Draft comment:
    Consider including isEECloudAccount in the condition for adding customDomainSettings, similar to the apiKeys logic above, unless there's a specific reason not to.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The refactoring of user role checks into variables is a good practice for readability and maintainability. However, the logic for adding customDomainSettings is only checking for isCloudAccount and isAdmin. It might be worth considering if isEECloudAccount should also be included, similar to the apiKeys logic.

Workflow ID: wflow_Dvm3yBR3HTZTAPh6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Jan 4, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 43b0cdb into main Jan 4, 2025
16 of 18 checks passed
@YounixM YounixM deleted the feat/custom-domain branch January 4, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs not required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants