-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(releaser): trigger charts releaser workflow on new release #6732
Conversation
Signed-off-by: Prashant Shahi <[email protected]>
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 35320bb in 37 seconds
More details
- Looked at
67
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. .github/workflows/prereleaser.yaml:11
- Draft comment:
The syntax for default value assignment in GitHub Actions should usedefault
, not||
.
RELEASE_TYPE: ${{ inputs.release_type || 'minor' }}
- Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. .github/workflows/releaser.yaml:29
- Draft comment:
The logic for determining the release type only checks if the patch number is non-zero for a 'patch' release. Consider adding logic to handle 'major' releases as well.
major_number=$(echo $release_tag | awk -F. '{print $1}')
minor_number=$(echo $release_tag | awk -F. '{print $2}')
release_type="patch"
if [[ $minor_number -eq 0 && $patch_number -eq 0 ]]; then
release_type="major"
elif [[ $patch_number -eq 0 ]]; then
release_type="minor"
fi
- Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The code is a new workflow file that handles release automation. While the comment points out a potential enhancement, we don't know if major version handling is actually needed. The current implementation might be intentionally simple. Without knowing the project's versioning requirements or seeing related files, we can't be sure this is a real issue.
The comment might be identifying a legitimate gap in version handling that could cause issues with major releases. The current code could potentially misclassify major releases as minor ones.
However, we don't have enough context to know if major releases need special handling or if the current simple approach is by design. The comment is somewhat speculative without more information.
The comment should be deleted as it's speculative and we don't have enough context to verify if major release handling is actually required.
3. .github/workflows/releaser.yaml:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This applies to the file structure used in this PR. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_1ikyBvRsdFTU11hp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Important
Adds a GitHub workflow to trigger the charts releaser on new SigNoz releases, renaming and creating workflows for this purpose.
releaser-signoz.yaml
toprereleaser.yaml
.releaser.yaml
to trigger charts releaser workflow on new SigNoz release.releaser.yaml
triggers on new release publication.actions/create-github-app-token@v1
to generate GitHub token.signoz/charts
repo to triggerprereleaser
event.minor
orpatch
) based on release tag inreleaser.yaml
.This description was created by for 35320bb. It will automatically update as commits are pushed.