Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add k8s pod name as quick filter for logs #6694

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Dec 21, 2024

Summary

  • add k8s pod name as quick filter attribute for logs

Important

Add K8s Pod Name as a quick filter in LogsQuickFiltersConfig in utils.tsx.

  • Feature:
    • Add K8s Pod Name as a quick filter in LogsQuickFiltersConfig in utils.tsx.
    • Uses k8s.pod.name as the attribute key with DataTypes.String and resource type.

This description was created by Ellipsis for 826508f. It will automatically update as commits are pushed.

@github-actions github-actions bot added enhancement New feature or request docs required labels Dec 21, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 826508f in 31 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/LogsExplorer/utils.tsx:115
  • Draft comment:
    The 'K8s Pod Name' filter is missing an 'id' field in the attributeKey object. Consider adding it for consistency and potential functionality requirements.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The id field appears optional since many existing filters work without it. The comment is speculative about "potential functionality requirements" without clear evidence. The new filter follows the same pattern as similar k8s filters. Without understanding the actual usage of this id field in the codebase, we can't be certain it's required.
    The id field might be important for some internal functionality that we can't see in this file. Some filters do have it, suggesting it could serve a purpose.
    However, most k8s-related filters work without the id field, and the comment is speculative about potential requirements rather than pointing out a concrete issue.
    Delete this comment as it's speculative and not supported by strong evidence in the code we can see. The new filter follows the same pattern as similar existing k8s filters.
2. frontend/src/pages/LogsExplorer/utils.tsx:115
  • Draft comment:
    The code looks good and follows the specified rules. No changes needed.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code does not violate any of the specified rules. It uses predefined constants and does not use inline styles or incorrect file structures.

Workflow ID: wflow_zQ1GXITlasuVgguK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25
Copy link
Collaborator Author

docs PR - SigNoz/signoz-web#1058

@vikrantgupta25 vikrantgupta25 merged commit 5d9a257 into main Dec 21, 2024
18 of 23 checks passed
@vikrantgupta25 vikrantgupta25 deleted the add-pod-name-quick-filter branch December 21, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs shipped enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants