chore: changed droprate view options values #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 806d944 in 12 seconds
More details
- Looked at
33lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:45
- Draft comment:
The initial value ofselectedIntervalwas changed from '5ms' to '10ms', which aligns with the new options. This is a correct change. - Reason this comment was not posted:
Confidence changes required:0%
The initial value ofselectedIntervalwas changed from '5ms' to '10ms', which aligns with the new options. This is a correct change.
2. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:100
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_Y2QJx9CkkTNLggdS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed drop rate options from -
1ms,2ms,5ms,10ms,15msto10ms,20ms,50ms,100ms,150ms,200ms,500msRelated Issues / PR's
Screenshots
Before -
After:
Screen.Recording.2024-12-21.at.12.01.14.PM.mov
Affected Areas and Manually Tested Areas
Tested droprate view dropdown selection and respective API payload and responses
Important
Updated drop rate options and default selection in
EvaluationTimeSelector.tsx.EvaluationTimeSelector.tsxfrom1ms,2ms,5ms,10ms,15msto10ms,20ms,50ms,100ms,150ms,200ms,500ms.5msto10msinEvaluationTimeSelector.tsx.This description was created by
for 806d944. It will automatically update as commits are pushed.