Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucketing for messaging queues #6669

Merged

Conversation

shivanshuraj1333
Copy link
Member

@shivanshuraj1333 shivanshuraj1333 commented Dec 18, 2024

Important

Adds time bucketing to SQL queries for Kafka messaging queues in sql.go, enhancing data filtering by tsBucketStart and tsBucketEnd.

  • Behavior:
    • Adds bucketing logic to SQL queries in sql.go for Kafka messaging queues.
    • Introduces tsBucketStart and tsBucketEnd to filter data within specific time buckets.
  • Functions:
    • Updates generateConsumerSQL(), generatePartitionLatencySQL(), generateConsumerPartitionLatencySQL() to include tsBucketStart and tsBucketEnd in WHERE clauses.
    • Modifies generateProducerPartitionThroughputSQL(), generateProducerTopicLatencySQL(), generateConsumerLatencySQL() similarly.
    • Adjusts generateConsumerServiceLatencySQL(), generateProducerSQL(), generateNetworkLatencyThroughputSQL() to use new bucketing logic.
    • Updates onboardProducersSQL() and onboardConsumerSQL() to incorporate time bucketing.

This description was created by Ellipsis for b21a5e8. It will automatically update as commits are pushed.

Copy link

request-info bot commented Dec 18, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b21a5e8 in 1 minute and 6 seconds

More details
  • Looked at 272 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/integrations/messagingQueues/kafka/sql.go:9
  • Draft comment:
    The calculation of tsBucketStart subtracts 1800 seconds from the start time, which may lead to incorrect bucketing. Ensure this is the intended behavior.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/query-service/app/integrations/messagingQueues/kafka/sql.go:6
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_cL2PDfTgP6ezZjce


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@shivanshuraj1333 shivanshuraj1333 merged commit 60dc479 into SigNoz:develop Dec 18, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants