update service.instance.id

[shivanshuraj1333]

Important

Update SQL queries to use resources_string for service.instance.id in sql.go.

• SQL Query Update:
  • Change attributes_string['service.instance.id'] to resources_string['service.instance.id'] in generateNetworkLatencyThroughputSQL and onboardConsumerSQL functions in sql.go.

^{This description was created by for d054bd2. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d054bd2 in 11 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. pkg/query-service/app/integrations/messagingQueues/kafka/sql.go:332

• Draft comment:
  Ensure that 'resources_string' is the correct source for 'service.instance.id'. This change should be consistent across the codebase.
• Reason this comment was not posted:
  Comment did not seem useful.

2. pkg/query-service/app/integrations/messagingQueues/kafka/sql.go:332

• Draft comment:
  Ensure consistency by using 'resources_string' for 'service.instance.id' as done in other parts of the code.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The code changes in the PR are correct and consistent with the existing codebase. The changes involve updating the SQL queries to use 'resources_string' instead of 'attributes_string' for 'service.instance.id'. This is consistent with the rest of the code where 'resources_string' is used for similar fields.

Workflow ID: wflow_SnST1H8A7ycERG0Z

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[request-info]

We would appreciate it if you could provide us with more info about this issue/pr!

[nityanandagohain]

Can you add the bucketing changes as well as @srikanthccv mentioned in #6663 (comment). . Here is how you add it https://signoz.io/docs/userguide/writing-clickhouse-traces-query/#timestamp-bucketing , https://signoz.io/docs/userguide/writing-clickhouse-traces-query/#examples

[nityanandagohain]

Please create the other pr with bucket changes

[shivanshuraj1333]

creating another PR for bucketing