Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: daemonsets implementation for K8s Infra Monitoring #6631

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Dec 13, 2024

Summary

daemonsets implementation for K8s Infra Monitoring

  • daemonsets list table
  • daemonset details page

Related Issues / PR's

N/A

Screenshots

Screenshot 2025-01-14 at 7 07 15 PM Screenshot 2025-01-14 at 7 07 06 PM

Affected Areas and Manually Tested Areas

Infra Monitoring section


Important

Adds DaemonSets monitoring to Kubernetes infrastructure with list and detailed views, including metrics, logs, traces, and events.

  • Behavior:
    • Implements DaemonSets list and details view in InfraMonitoringK8s.
    • Adds getK8sDaemonSetsList function to fetch DaemonSets data.
    • Supports filtering, sorting, and pagination for DaemonSets.
    • Integrates metrics, logs, traces, and events views for DaemonSets.
  • Components:
    • Adds K8sDaemonSetsList component for listing DaemonSets.
    • Adds DaemonSetDetails component for detailed view with tabs for metrics, logs, traces, and events.
    • Implements DaemonSetMetrics, DaemonSetLogs, DaemonSetTraces, and DaemonSetEvents components.
  • Styles:
    • Adds styles for DaemonSets components in DaemonSetDetails.styles.scss, DaemonSetLogs.styles.scss, etc.
  • API:
    • Defines K8sDaemonSetsListPayload and K8sDaemonSetsListResponse interfaces.
    • Adds useGetK8sDaemonSetsList hook for querying DaemonSets data.
  • Misc:
    • Updates reactQueryKeys.ts with GET_DAEMONSET_LIST key.
    • Adds constants and utility functions for DaemonSets handling.

This description was created by Ellipsis for 19fd8be. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2024
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch 5 times, most recently from b5d57e1 to ba944d0 Compare December 24, 2024 06:53
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from 186f768 to 6d441f3 Compare December 27, 2024 04:04
Base automatically changed from feat/infra-monitoring-k8s-nodes to feat/infra-monitoring-k8s January 3, 2025 06:09
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s branch from c89ffab to 79cae2d Compare January 3, 2025 06:14
@YounixM YounixM force-pushed the feat/infra-monitoring-k8s branch from a294614 to 6855009 Compare January 6, 2025 05:56
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s branch from 2edb730 to 579c7cb Compare January 8, 2025 05:21
@YounixM YounixM force-pushed the feat/infra-monitoring-k8s branch from 579c7cb to 22a33e3 Compare January 8, 2025 10:32
Base automatically changed from feat/infra-monitoring-k8s to main January 8, 2025 10:44
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-daemon-sets branch from 9ef4c0c to 45065f9 Compare January 14, 2025 13:39
@amlannandy amlannandy changed the title feat: implement daemonSets list table for infra monitoring feat: daemonsets implementation for K8s Infra Monitoring Jan 14, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@amlannandy amlannandy marked this pull request as ready for review January 14, 2025 13:41
@amlannandy amlannandy requested a review from YounixM as a code owner January 14, 2025 13:41
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 45065f9 in 1 minute and 56 seconds

More details
  • Looked at 4781 lines of code in 33 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/src/api/infraMonitoring/getK8sDaemonSetsList.ts:69
  • Draft comment:
    Consider adding more specific error handling for network or server errors to prevent unhandled promise rejections.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function getK8sDaemonSetsList is used to fetch data, but there is no error handling for network or server errors. This could lead to unhandled promise rejections or uncaught errors in the application.
2. frontend/src/hooks/infraMonitoring/useGetK8sDaemonSetsList.ts:48
  • Draft comment:
    Ensure that error handling is implemented for the query function to manage network or server errors effectively.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The useGetK8sDaemonSetsList hook does not handle errors explicitly. It relies on the default behavior of useQuery, which might not be sufficient for all use cases.
3. frontend/src/container/InfraMonitoringK8s/DaemonSets/K8sDaemonSetsList.tsx:318
  • Draft comment:
    Add a check to ensure groupedByRowData is defined before accessing its properties to prevent runtime errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The expandedRowRender function in K8sDaemonSetsList.tsx does not handle the case where groupedByRowData is undefined, which could lead to runtime errors.
4. frontend/src/container/InfraMonitoringK8s/DaemonSets/K8sDaemonSetsList.tsx:243
  • Draft comment:
    Ensure that sorter has a field and order before using them to set orderBy to prevent unexpected behavior.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The handleTableChange function in K8sDaemonSetsList.tsx does not handle the case where sorter might not have a field or order, which could lead to unexpected behavior.

Workflow ID: wflow_f28laOYQ9kXBY0Zi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@amlannandy amlannandy changed the base branch from main to feat/infra-monitoring-k8s-jobs January 20, 2025 07:28
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-daemon-sets branch from 45065f9 to 19fd8be Compare January 21, 2025 05:46
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@amlannandy amlannandy merged commit abdbd60 into feat/infra-monitoring-k8s-jobs Jan 21, 2025
6 of 7 checks passed
@amlannandy amlannandy deleted the feat/infra-monitoring-k8s-daemon-sets branch January 21, 2025 05:47
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 19fd8be in 1 minute and 20 seconds

More details
  • Looked at 4773 lines of code in 32 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/hooks/infraMonitoring/useGetK8sDaemonSetsList.ts:38
  • Draft comment:
    Ensure the query key is always an array for consistency with React Query's caching mechanism.
return [options.queryKey];
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code in useGetK8sDaemonSetsList.ts is mostly fine, but there's a minor issue with the query key generation. The query key should always be an array to ensure consistency and avoid potential issues with React Query's caching mechanism.
2. frontend/src/container/InfraMonitoringK8s/DaemonSets/utils.tsx:242
  • Draft comment:
    Use design tokens or predefined color constants instead of hardcoding color values for consistency.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_KWyT3ixhpVLfl66L


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant