[Theme Checks] Ensuring importmap is not being used on script tags in theme app extensions #682
+98
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
As of Jan 6th this PR will not be shipping until more clarification is sought on whether or not this needs to be a SFR fix rather than a theme check due to browsers supporting multiple importmaps in the future - see discussion in issue below for more clarification.
Part 1 of #647
This PR tackles adding in a theme check for theme app extensions that will ensure that users are not adding
script
tags in theme app extensions with typeimportmap
. The reason this is split into multiple PRs is to keep the theme check focused as the other portion will target typemodule
and only on app embeds that targetcompliance_head
.What's next? Any followup issues?
Part 2 of #647 that will target app embeds that target
compliance_head
.What did you learn?
What importmaps are 💃
Before you deploy
changeset
allChecks
array insrc/checks/index.ts
yarn build
and committed the updated configuration filestheme-app-extension.yml
configchangeset
changeset