Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Checks] Ensuring importmap is not being used on script tags in theme app extensions #682

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AribaRajput
Copy link
Contributor

@AribaRajput AribaRajput commented Jan 2, 2025

What are you adding in this PR?

As of Jan 6th this PR will not be shipping until more clarification is sought on whether or not this needs to be a SFR fix rather than a theme check due to browsers supporting multiple importmaps in the future - see discussion in issue below for more clarification.

Part 1 of #647

This PR tackles adding in a theme check for theme app extensions that will ensure that users are not adding script tags in theme app extensions with type importmap. The reason this is split into multiple PRs is to keep the theme check focused as the other portion will target type module and only on app embeds that target compliance_head.

What's next? Any followup issues?

Part 2 of #647 that will target app embeds that target compliance_head.

What did you learn?

What importmaps are 💃

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

theme block theme check

Finished tests

Added changeset
@AribaRajput AribaRajput force-pushed the ariba/importmap-check branch 2 times, most recently from b564adc to 99c2512 Compare January 2, 2025 16:08
@AribaRajput AribaRajput marked this pull request as ready for review January 2, 2025 16:14
@AribaRajput AribaRajput requested a review from a team as a code owner January 2, 2025 16:15
@AribaRajput AribaRajput force-pushed the ariba/importmap-check branch 2 times, most recently from d39b85e to 5a5049b Compare January 2, 2025 19:18
@AribaRajput AribaRajput force-pushed the ariba/importmap-check branch from 5a5049b to 4466641 Compare January 2, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant