-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pnpm, yarn & bun support #42
base: main
Are you sure you want to change the base?
Add pnpm, yarn & bun support #42
Conversation
"common-tags": "^1.8.2", | ||
"detect-package-manager": "^3.0.1", | ||
"semver": "^7.5.4", | ||
"which": "^4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this works on Windows runners? Didn't see a comment about it in the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm looks like it does:
https://github.com/npm/node-which/blob/main/lib/index.js#L4
I didn't test this, I only saw that in the logs from the report and it looked sus. Haven't played with pnpm yet, never felt the need to upgrade tbh (and every time I see a pnpm related issue, it feels like a waste of time 😅. I see a whole lot more of those than yarn.) |
I don't think that |
@charlespwd What is the status on this? Running This is my action with This is my action without running Notice I do this because I am compiling JS and CSS. Theme Check will return errors for |
This PR makes the action use the package manager defined by the repository. If the package isn't available for the runner, it will fall back to
npm
.@charlespwd comment
Not sure if this was incorrect. Does this action output errors in the job log?
Kept it as local install in this PR.
Tested with
Resolves #37