[Feature] Add signal option to allow aborting requests #1972
+101
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sle-c
reviewed
Jan 16, 2025
sle-c
reviewed
Jan 16, 2025
There was a problem hiding this comment.
i think this might an accident commit
There was a problem hiding this comment.
🤦♀️ should be fixed
This allows developers to abort requests if responses are not recieved in sufficient time Can be used to set a custom timeout per request If the request is aborted an error will be thrown update docs
lizkenyon
force-pushed
the
liz/add-abort-signal
branch
from
55f5619 to
89d803e
Compare
sle-c
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes Http request error, no response available: GraphQL Client: fetch failed
WHAT is this pull request doing?
This PR adds an option to pass an
AbortSignalto requestsThis will allow developers to set their own timeouts for individual requests, this will allow developers more flexibility to handle fetch errors
The base functionality was already added to the GraphQL client in this PR, this just adds the functionality to pass this option through.
Type of change
Checklist
pnpm changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)