Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Authenticate requests from POS UI extensions #1961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feature] Authenticate requests from POS UI extensions #1961

wants to merge 1 commit into from
+339 −2

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

Fixes # 756

WHAT is this pull request doing?

  • Adds new method to authenticate requests for POS UI extensions
  • POS UI extensions follow the same authentication method as Checkout UI extensions

https://github.com/user-attachments/assets/12a46342-0b22-4931-bbf9-c41f10ec31ef
https://github.com/user-attachments/assets/bc509672-8076-48aa-95c7-49a39b72bc79

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@lizkenyon lizkenyon requested a review from a team as a code owner January 13, 2025 22:15
sle-c
sle-c approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks the same as checkout extension auth as you mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sle-c sle-c sle-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizkenyon @sle-c