Handle module_function with no arguments #3018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2653
This PR handles the other missing part of
module_function
, which is when it gets invoked with no argument. After looking into the Ruby source code, it seems thatmodule_func
is a flag considered as part of the visibility scope.Invoking
module_function
will both:private
into the stackImplementation
I created a new
VisibilityScope
object to help us encapsulate all aspects of visibility, so that we don't forget to handlemodule_func
where necessary.Then I started handling the case of
module_function
with no arguments, which essentially pushes a new scope into the stack withmodule_func: true
and visibility private.Automated Tests
Added a few tests.