[FullscreenBar] Fix invisible BackButton color within Styleguide #13054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beefchimi
added
the
Bug
beefchimi
commented
Jan 17, 2025
| @@ -6,7 +6,7 @@ import {motion, AnimatePresence} from 'framer-motion'; | |||
|
|
|||
| import GlobalSearch from '../GlobalSearch'; | |||
| import nav from '../../../.cache/nav'; | |||
| import {NavItem, Breakpoints} from '../../types'; | |||
| import {type NavItem, Breakpoints} from '../../types'; | |||
There was a problem hiding this comment.
I made this change because the IDE was complaining. We define NavItem as a component elsewhere in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I noticed while reviewing the Polaris Styleguide that the
FullscreenBar > BackButtonwas... invisible. I then noticed:So, there must be some styling from outside the
<iframe />that is causing this...dark-mode-bug.mov
WHAT is this pull request doing?
I've simply applied
color: var(--p-color-text)to theBackButton. This appears to resolve the issue without introducing any negative side effects... but of course, I may have gone about this incorrectly.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Please tophat this by running the Styleguide locally. You will want to make sure you blow away any previous
polarisbundle that the Styleguide consumers. I simply did the following:pnpm cleanpnpm installpnpm buildpnpm turbo run dev --filter=polaris.shopify.comFullscreenBarpage and toggle betweenlight/darkmode from the Styleguide header.🎩 checklist
README.mdwith documentation changes