Introduce MaintenanceTasks::Task.rescue_from #1150
Open
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewn617
force-pushed
the
rescue-from
branch
from
0d540de to
98aa21c
Compare
andrewn617
requested review from
etiennebarrie,
adrianna-chang-shopify,
rafaelfranca and
nvasilevski
and removed request for
etiennebarrie
nvasilevski
reviewed
Jan 21, 2025
|
I'd like to do this just be including |
andrewn617
force-pushed
the
rescue-from
branch
5 times, most recently
from
665666b to
8cdc2db
Compare
|
@kmcphillips I added support for 6.1 (and tested it locally) but ci just seems broken for 6.1 🤔 So maybe we should just remove it. |
README.md
Outdated
| the task with error. Errors can be rescued using the `rescue_from` handler. Errors | ||
| rescued this way will be reported by the handler and iteration will continue. | ||
|
|
||
| The default handler just calls `Rails.error.report` with the raised error. |
There was a problem hiding this comment.
Suggested change
| The default handler just calls `Rails.error.report` with the raised error. | |
| The default handler calls `Rails.error.report` with the raised error: |
kmcphillips
reviewed
Jan 22, 2025
andrewn617
force-pushed
the
rescue-from
branch
from
8cdc2db to
a79137a
Compare
MaintenanceTasks::Task.report_on takes a list of exceptions. When the task is iterating those exceptions will be rescued and reported to the error reporter, then iteration will continue.
andrewn617
force-pushed
the
rescue-from
branch
from
a79137a to
6a95c12
Compare
|
After some discussion, I am going to use For consistency's sake, I deprecated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default any errors encountered while processing an iteration will be raised and the task with error. In our app we noticed a lot developers writing very similar code to rescue some exceptions, report them and moving on to the next iteration. So, let's introduce a helper to make this easier.
We introduced a
report_onmethod toMaintenancneTask::Tasks. Exceptions passed to this method will be rescued during iteration and reported the rails error reporter, then iteration will continue.