Support keyword arguments in iteration jobs #536
+53
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now more common to have jobs that take keyword arguments, like `MyJob.perform_later(foo: "bar")`. But under the current implementation, `build_enumerator` can only take them as a hash argument instead of keyword arguments: ```ruby def build_enumerator(params) foo = params[:foo] # ... end ``` This commit fixes that by allowing keyword arguments to be passed to `build_enumerator` and `each_iteration`.
st0012
force-pushed
the
make-jobs-take-keyword-arguments
branch
from
54febaf to
04ab475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now more common to have jobs that take keyword arguments, like
MyJob.perform_later(foo: "bar"). But under the current implementation,build_enumeratorcan only take them as a hash argument instead of keyword arguments:This commit improves that by allowing keyword arguments to be passed to
build_enumeratorandeach_iterationas: