Bump theme check action and fix theme check error #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2025
aswamy
approved these changes
Jan 14, 2025
| @@ -7,3 +7,4 @@ | |||
| .Trashes | |||
| ehthumbs.db | |||
| Thumbs.db | |||
| .shopify | |||
mxstbr
approved these changes
Jan 14, 2025
graygilmore
force-pushed
the
gg-fix-theme-check-action
branch
2 times, most recently
from
a0d4da6 to
ebb5ca6
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
theme-check-action@v1uses the Ruby implementation of theme check which has previously been deprecated and now is fully removed from the Shopify CLI. This bumps the action to use v2.This means that the action is now using the same version of the theme checker that we'd be using when running
shopify theme checklocally which means that we also needed to fix an error insections/header.liquid.One additional commit here adds
.shopifyto the.gitignorefile now thatshopify theme devdownloads metafield definitions by default (See Shopify/cli#5184 for more information).Checklist