[chore] ♻️ Refactor onConnect listener creation to a util function #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintonC
added
🤖Skip Changelog
Package: connect-wallet
Area: Testing 🧪
QuintonC
requested review from
jamiely,
Soleone,
caropinzonsilva,
lesliexin,
Borahm and
imjameshall
as code owners
|
/snapit |
|
🫰✨ Thanks @QuintonC! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
You can test this PR using this CodeSandbox |
jamiely
approved these changes
Feb 15, 2023
|
|
||
| return unsubscribeToOnConnectListener; | ||
| return dispatch(listener); | ||
| }, [dispatch, onConnect, requireSignature]); |
There was a problem hiding this comment.
is requireSignature still a dependency?
There was a problem hiding this comment.
is
requireSignaturestill a dependency?
Nope! Good eye. That also removes some other lines from the hook. Thanks!
QuintonC
force-pushed
the
chore/listener-simplification
branch
from
b6ad1ca to
2068be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for these changes?
Refactors and simplifies the
onConnectlistener logic. This allows for easier middleware creation foronConnectevents by removing the possibility to missed actions (if the actions foronConnectlogic are to ever change) and DRYs up the creation of listeners.The inspiration behind this was not only to DRY up the code a bit, but also because in #4 I am going to re-use this logic (it could likely be reused in #13 as well) for looking up ENS names when a wallet connects.
Note: I was going to add tests for
useMiddleware.tsas well, however I noticed that we need to create some form of app context in order to render hooks with the state provider. I'd prefer for that to be done the right way, and I believe that doing so will make this PR larger than it should be.How can this be tophatted?
Primarily green CI (I've added tests for the functionality). However, I will also run
/snapitand link a CodeSandbox with the snapshot version for testing.Test CodeSandbox
🎩 Checklist
Tested for accessibilityN/AUpdated relevant documentation for the changes (if necessary)N/A