Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(install): Get reference for Users group via Enum #6278

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

refack
Copy link

@refack refack commented Jan 23, 2025

Description

  1. Update function description to reflect current logic
  2. Get the reference to the well-known Users Group by using the WellKnown enum, instead of a magic string.

Motivation and Context

Make intended object name strongly typed and explicitly named.
Should be easier for humans to read and understand

How Has This Been Tested?

  1. Step debugger confirms the resulting object is identical.
  2. Current test suit has not regressed.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • [] I have updated the documentation accordingly.
  • [] I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@refack
Copy link
Author

refack commented Jan 23, 2025

Hello all

I'm dipping my toe in the codebase and thought this might be a nice and small first PR.
Do I need to add a line in the changelog for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant